Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[test-only] [back-port] Change naming in sharingNG api-tests #8159

Merged
merged 1 commit into from
Jan 9, 2024

Conversation

SwikritiT
Copy link
Contributor

Backport #8140

@SwikritiT SwikritiT self-assigned this Jan 9, 2024
Copy link

update-docs bot commented Jan 9, 2024

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@SwikritiT SwikritiT marked this pull request as ready for review January 9, 2024 08:25
Copy link
Contributor

@ScharfViktor ScharfViktor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @SwikritiT for caring 👍

@saw-jan
Copy link
Member

saw-jan commented Jan 9, 2024

looks like it needs some extra changes
https://drone.owncloud.com/owncloud/ocis/30775/24/6

Notice: Undefined variable: role in /drone/src/tests/acceptance/features/bootstrap/SharingNgContext.php line 155

@SwikritiT SwikritiT force-pushed the tests/backport/8140 branch from edf7713 to 086c246 Compare January 9, 2024 09:31
@SwikritiT
Copy link
Contributor Author

looks like it needs some extra changes https://drone.owncloud.com/owncloud/ocis/30775/24/6

Notice: Undefined variable: role in /drone/src/tests/acceptance/features/bootstrap/SharingNgContext.php line 155

done

@SwikritiT SwikritiT force-pushed the tests/backport/8140 branch from 086c246 to 615a260 Compare January 9, 2024 11:00
@SwikritiT SwikritiT force-pushed the tests/backport/8140 branch from 615a260 to 4f62cf5 Compare January 9, 2024 11:03
Copy link

sonarqubecloud bot commented Jan 9, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@saw-jan saw-jan merged commit c80a4b1 into stable-5.0 Jan 9, 2024
4 checks passed
@delete-merged-branch delete-merged-branch bot deleted the tests/backport/8140 branch January 9, 2024 12:39
ownclouders pushed a commit that referenced this pull request Jan 9, 2024
Co-authored-by: Viktor Scharf <[email protected]>
ownclouders pushed a commit that referenced this pull request Jan 10, 2024
Co-authored-by: Viktor Scharf <[email protected]>
ownclouders pushed a commit that referenced this pull request Jan 10, 2024
Co-authored-by: Viktor Scharf <[email protected]>
saw-jan pushed a commit that referenced this pull request Jan 16, 2024
nirajacharya2 pushed a commit that referenced this pull request Jan 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants