[tests-only] tests: refactor test script for removing permission from share #8134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
SwikritiT
changed the title
SwikritiT
requested review from
grgprarup,
SagarGi,
saw-jan,
amrita-shrestha and
ScharfViktor
SwikritiT
commented
Jan 5, 2024
| @@ -179,11 +200,22 @@ public function getSharesEndpointPath(?string $postfix = ''):string { | |||
| public function shareNgGetLastCreatedLinkShareID(): string { | |||
| $lastResponse = $this->shareNgGetLastCreatedLinkShare(); | |||
| if (!isset($this->getJsonDecodedResponse($lastResponse)['id'])) { | |||
| throw new Error('Response did not contain share id ' . $this->getJsonDecodedResponse($lastResponse)['id'] . ' for the created public link'); | |||
There was a problem hiding this comment.
removed this because if $this->getJsonDecodedResponse($lastResponse)['id'] is not set it'll probably come undefined. so the error message might not make use of that
saw-jan
reviewed
Jan 5, 2024
ScharfViktor
approved these changes
Jan 5, 2024
saw-jan
force-pushed
the
tests/refactor-remove-share-permission
branch
2 times, most recently
from
1cb694a to
0358930
Compare
SwikritiT
force-pushed
the
tests/refactor-remove-share-permission
branch
from
0358930 to
3c383a3
Compare
SwikritiT
force-pushed
the
tests/refactor-remove-share-permission
branch
from
3c383a3 to
87e5116
Compare
|
saw-jan
approved these changes
Jan 9, 2024
delete-merged-branch
bot
deleted the
tests/refactor-remove-share-permission
branch
ownclouders
pushed a commit
that referenced
this pull request
Jan 9, 2024
… share (#8134) * tests: refactor test script for removing permission from share * address reviews --------- Co-authored-by: Saw-jan <[email protected]>
saw-jan
added a commit
that referenced
this pull request
Jan 16, 2024
… share (#8134) * tests: refactor test script for removing permission from share * address reviews --------- Co-authored-by: Saw-jan <[email protected]>
nirajacharya2
pushed a commit
that referenced
this pull request
Jan 22, 2024
… share (#8134) * tests: refactor test script for removing permission from share * address reviews --------- Co-authored-by: Saw-jan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Previously I fetched the
permissionIdwith the extra request but thepermissionIdis what we knew to beshareIdso we can store the shareId directly from the share invite response and use it from the stored array. This removes the necessity for extra request.Related Issue
#8008