Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tests-only][full-ci]Added tests for setting password in a public share link #8079

Merged
merged 5 commits into from
Jan 5, 2024

Conversation

SagarGi
Copy link
Member

@SagarGi SagarGi commented Dec 28, 2023

Description

This PR adds the tests scenarios to set and update(if already created) the password for the public link share for shareNg

Scenario: set password for a file's link share
Scenario: update password for a file's link share

Related Issue:

#7968

@SagarGi SagarGi self-assigned this Dec 28, 2023
@SagarGi SagarGi force-pushed the CreateShare/setPassword branch 3 times, most recently from 42e546a to 9c2d2e1 Compare January 3, 2024 06:03
@SagarGi SagarGi marked this pull request as ready for review January 3, 2024 06:06
@SagarGi SagarGi force-pushed the CreateShare/setPassword branch from 9c2d2e1 to f7b1706 Compare January 4, 2024 03:56
@SagarGi SagarGi requested a review from saw-jan January 4, 2024 03:56
@SagarGi SagarGi force-pushed the CreateShare/setPassword branch from b32b2f0 to 62a51e4 Compare January 4, 2024 11:31
@SagarGi SagarGi requested a review from saw-jan January 4, 2024 11:31
@SagarGi SagarGi requested a review from ScharfViktor January 5, 2024 03:39
Copy link
Member

@saw-jan saw-jan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Others LGTM

@SagarGi SagarGi force-pushed the CreateShare/setPassword branch from 62a51e4 to ae07acb Compare January 5, 2024 03:59
@SagarGi SagarGi requested a review from saw-jan January 5, 2024 03:59
@SagarGi SagarGi force-pushed the CreateShare/setPassword branch from ae07acb to 1feb532 Compare January 5, 2024 06:10
Copy link

sonarqubecloud bot commented Jan 5, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@SagarGi SagarGi merged commit c46db2b into master Jan 5, 2024
4 checks passed
@delete-merged-branch delete-merged-branch bot deleted the CreateShare/setPassword branch January 5, 2024 08:13
ownclouders pushed a commit that referenced this pull request Jan 5, 2024
…re link (#8079)

* Added tests for set/update for password for public link

* Added assertion step for password update

* Rebase and refactor setPassword step

Signed-off-by: [email protected] <[email protected]>

* Review Address

* Review Address

---------

Signed-off-by: [email protected] <[email protected]>
saw-jan pushed a commit that referenced this pull request Jan 8, 2024
…re (#8079) (#8138)

* Added tests for set/update for password for public link

* Added assertion step for password update

* Rebase and refactor setPassword step

Signed-off-by: [email protected] <[email protected]>

* Review Address

* Review Address

* Fix style

---------

Signed-off-by: [email protected] <[email protected]>
ownclouders pushed a commit that referenced this pull request Jan 8, 2024
…re (#8079) (#8138)

* Added tests for set/update for password for public link

* Added assertion step for password update

* Rebase and refactor setPassword step

Signed-off-by: [email protected] <[email protected]>

* Review Address

* Review Address

* Fix style

---------

Signed-off-by: [email protected] <[email protected]>
dragonchaser pushed a commit to dragonchaser/ocis that referenced this pull request Jan 15, 2024
…re (owncloud#8079) (owncloud#8138)

* Added tests for set/update for password for public link

* Added assertion step for password update

* Rebase and refactor setPassword step

Signed-off-by: [email protected] <[email protected]>

* Review Address

* Review Address

* Fix style

---------

Signed-off-by: [email protected] <[email protected]>
saw-jan pushed a commit that referenced this pull request Jan 16, 2024
…re (#8079) (#8138)

* Added tests for set/update for password for public link

* Added assertion step for password update

* Rebase and refactor setPassword step

Signed-off-by: [email protected] <[email protected]>

* Review Address

* Review Address

* Fix style

---------

Signed-off-by: [email protected] <[email protected]>
nirajacharya2 pushed a commit that referenced this pull request Jan 22, 2024
…re (#8079) (#8138)

* Added tests for set/update for password for public link

* Added assertion step for password update

* Rebase and refactor setPassword step

Signed-off-by: [email protected] <[email protected]>

* Review Address

* Review Address

* Fix style

---------

Signed-off-by: [email protected] <[email protected]>
2403905 pushed a commit to 2403905/ocis that referenced this pull request Jan 24, 2024
…re link (owncloud#8079)

* Added tests for set/update for password for public link

* Added assertion step for password update

* Rebase and refactor setPassword step

Signed-off-by: [email protected] <[email protected]>

* Review Address

* Review Address

---------

Signed-off-by: [email protected] <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants