-
Notifications
You must be signed in to change notification settings - Fork 187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[tests-only][full-ci]Added tests for setting password in a public share link #8079
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10 tasks
SagarGi
force-pushed
the
CreateShare/setPassword
branch
3 times, most recently
from
January 3, 2024 06:03
42e546a
to
9c2d2e1
Compare
SagarGi
requested review from
ScharfViktor,
PrajwolAmatya,
phil-davis,
grgprarup,
SwikritiT,
saw-jan,
Salipa-Gurung,
amrita-shrestha,
nabim777,
S-Panta and
nirajacharya2
January 3, 2024 06:05
saw-jan
reviewed
Jan 3, 2024
saw-jan
reviewed
Jan 3, 2024
saw-jan
reviewed
Jan 3, 2024
saw-jan
reviewed
Jan 3, 2024
saw-jan
reviewed
Jan 3, 2024
saw-jan
reviewed
Jan 3, 2024
saw-jan
reviewed
Jan 3, 2024
saw-jan
reviewed
Jan 3, 2024
saw-jan
reviewed
Jan 3, 2024
SagarGi
force-pushed
the
CreateShare/setPassword
branch
from
January 4, 2024 03:56
9c2d2e1
to
f7b1706
Compare
saw-jan
reviewed
Jan 4, 2024
SagarGi
force-pushed
the
CreateShare/setPassword
branch
from
January 4, 2024 11:31
b32b2f0
to
62a51e4
Compare
ScharfViktor
reviewed
Jan 4, 2024
saw-jan
reviewed
Jan 5, 2024
saw-jan
reviewed
Jan 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Others LGTM
SagarGi
force-pushed
the
CreateShare/setPassword
branch
from
January 5, 2024 03:59
62a51e4
to
ae07acb
Compare
saw-jan
approved these changes
Jan 5, 2024
SagarGi
force-pushed
the
CreateShare/setPassword
branch
from
January 5, 2024 06:10
ae07acb
to
1feb532
Compare
Quality Gate passedKudos, no new issues were introduced! 0 New issues |
ownclouders
pushed a commit
that referenced
this pull request
Jan 5, 2024
…re link (#8079) * Added tests for set/update for password for public link * Added assertion step for password update * Rebase and refactor setPassword step Signed-off-by: [email protected] <[email protected]> * Review Address * Review Address --------- Signed-off-by: [email protected] <[email protected]>
saw-jan
pushed a commit
that referenced
this pull request
Jan 8, 2024
…re (#8079) (#8138) * Added tests for set/update for password for public link * Added assertion step for password update * Rebase and refactor setPassword step Signed-off-by: [email protected] <[email protected]> * Review Address * Review Address * Fix style --------- Signed-off-by: [email protected] <[email protected]>
ownclouders
pushed a commit
that referenced
this pull request
Jan 8, 2024
…re (#8079) (#8138) * Added tests for set/update for password for public link * Added assertion step for password update * Rebase and refactor setPassword step Signed-off-by: [email protected] <[email protected]> * Review Address * Review Address * Fix style --------- Signed-off-by: [email protected] <[email protected]>
dragonchaser
pushed a commit
to dragonchaser/ocis
that referenced
this pull request
Jan 15, 2024
…re (owncloud#8079) (owncloud#8138) * Added tests for set/update for password for public link * Added assertion step for password update * Rebase and refactor setPassword step Signed-off-by: [email protected] <[email protected]> * Review Address * Review Address * Fix style --------- Signed-off-by: [email protected] <[email protected]>
saw-jan
pushed a commit
that referenced
this pull request
Jan 16, 2024
…re (#8079) (#8138) * Added tests for set/update for password for public link * Added assertion step for password update * Rebase and refactor setPassword step Signed-off-by: [email protected] <[email protected]> * Review Address * Review Address * Fix style --------- Signed-off-by: [email protected] <[email protected]>
nirajacharya2
pushed a commit
that referenced
this pull request
Jan 22, 2024
…re (#8079) (#8138) * Added tests for set/update for password for public link * Added assertion step for password update * Rebase and refactor setPassword step Signed-off-by: [email protected] <[email protected]> * Review Address * Review Address * Fix style --------- Signed-off-by: [email protected] <[email protected]>
2403905
pushed a commit
to 2403905/ocis
that referenced
this pull request
Jan 24, 2024
…re link (owncloud#8079) * Added tests for set/update for password for public link * Added assertion step for password update * Rebase and refactor setPassword step Signed-off-by: [email protected] <[email protected]> * Review Address * Review Address --------- Signed-off-by: [email protected] <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the tests scenarios to set and update(if already created) the password for the public link share for shareNg
Related Issue:
#7968