[tests-only][full-ci]Added test to update role and expiration date for share link (v1beta1) #8071
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SagarGi
changed the title
10 tasks
SagarGi
requested review from
phil-davis,
grgprarup,
saw-jan,
Salipa-Gurung,
amrita-shrestha,
nabim777,
S-Panta,
PrajwolAmatya,
ScharfViktor and
nirajacharya2
saw-jan
reviewed
Dec 28, 2023
saw-jan
reviewed
Dec 28, 2023
saw-jan
reviewed
Dec 28, 2023
saw-jan
reviewed
Dec 28, 2023
SagarGi
force-pushed
the
CreateShare/updateLink
branch
2 times, most recently
from
98c00d2 to
a8de3c3
Compare
SagarGi
force-pushed
the
CreateShare/updateLink
branch
3 times, most recently
from
8f0ce34 to
16c5822
Compare
grgprarup
reviewed
Jan 1, 2024
| }, | ||
| "expirationDateTime": { | ||
| "type": "string", | ||
| "enum": ["2201-07-15T23:59:59Z"] |
There was a problem hiding this comment.
Is this the expected expiry date?
When the share invitation for a resource (file/folder) is sent with an expiry date 2200-07-15T14:00:00.000Z, then the date in response is 2200-07-15T14:00:00Z.
There was a problem hiding this comment.
yes its the updated expiry date!
There was a problem hiding this comment.
My question here is why the expiration date is set differently for a public link. Isn't the time must be set to 14:00:00 instead of 23:59:59?
There was a problem hiding this comment.
It is expected.
Niraj Acharya(Jankari Tech): when i create a share link for a file and set the expiration date to some thing like Friday, December 15, 2023 12:00:00 AM the experation date is set to Friday, December 15, 2023 11:59:59 PM. does the createLink endpoint set the expiration date to the last second of the day and not the given date?
https://owncloud.dev/libre-graph-api/#/drives.permissions/CreateLinkMichael Barz: Yes that is correct. The OCS was behaving exactly like that.
grgprarup
reviewed
Jan 1, 2024
SagarGi
force-pushed
the
CreateShare/updateLink
branch
from
16c5822 to
b501cb5
Compare
saw-jan
reviewed
Jan 1, 2024
saw-jan
reviewed
Jan 1, 2024
saw-jan
reviewed
Jan 1, 2024
saw-jan
reviewed
Jan 1, 2024
saw-jan
reviewed
Jan 1, 2024
saw-jan
reviewed
Jan 1, 2024
saw-jan
reviewed
Jan 1, 2024
saw-jan
reviewed
Jan 1, 2024
SagarGi
force-pushed
the
CreateShare/updateLink
branch
from
b501cb5 to
00d6d37
Compare
|
SwikritiT
approved these changes
Jan 2, 2024
SagarGi
added a commit
that referenced
this pull request
Jan 2, 2024
…r share link (v1beta1) (#8071) * Added test to update role and expiration date for share link Signed-off-by: [email protected] <[email protected]> * Review address --------- Signed-off-by: [email protected] <[email protected]>
ownclouders
pushed a commit
that referenced
this pull request
Jan 2, 2024
…r share link (v1beta1) (#8071) * Added test to update role and expiration date for share link Signed-off-by: [email protected] <[email protected]> * Review address --------- Signed-off-by: [email protected] <[email protected]>
saw-jan
pushed a commit
that referenced
this pull request
Jan 2, 2024
…r share link (v1beta1) (#8071) (#8103) * Added test to update role and expiration date for share link * Review address --------- Signed-off-by: [email protected] <[email protected]>
ownclouders
pushed a commit
that referenced
this pull request
Jan 2, 2024
…r share link (v1beta1) (#8071) (#8103) * Added test to update role and expiration date for share link * Review address --------- Signed-off-by: [email protected] <[email protected]>
ownclouders
pushed a commit
that referenced
this pull request
Jan 3, 2024
…r share link (v1beta1) (#8071) (#8103) * Added test to update role and expiration date for share link * Review address --------- Signed-off-by: [email protected] <[email protected]>
nirajacharya2
pushed a commit
that referenced
this pull request
Jan 22, 2024
…r share link (v1beta1) (#8071) (#8103) * Added test to update role and expiration date for share link * Review address --------- Signed-off-by: [email protected] <[email protected]>
2403905
pushed a commit
to 2403905/ocis
that referenced
this pull request
Jan 24, 2024
…r share link (v1beta1) (owncloud#8071) * Added test to update role and expiration date for share link Signed-off-by: [email protected] <[email protected]> * Review address --------- Signed-off-by: [email protected] <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds test scenarios for updating
rolesandexpiration datefor the created share linkRelated Issue:
#7968