Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tests-only][full-ci]Added tests for creating link for a resource #7982

Merged
merged 2 commits into from
Dec 20, 2023
Merged

[tests-only][full-ci]Added tests for creating link for a resource #7982

merged 2 commits into from
Dec 20, 2023

Conversation

SagarGi
Copy link
Member

@SagarGi SagarGi commented Dec 15, 2023 •
edited
Loading

Description

This PR adds the implementation for new v1beta1 graph-api to create a share link with different roles.

Scenario Outline: create a link share of a folder
Scenario Outline: create a link share of a file

Related Issue:

#7968

@SagarGi SagarGi self-assigned this Dec 15, 2023
@SagarGi SagarGi mentioned this pull request Dec 15, 2023
Closed
10 tasks
@SagarGi SagarGi force-pushed the sharingAPI/createLink branch from 63b5506 to 1bd7908 Compare December 19, 2023 11:17
@SagarGi SagarGi marked this pull request as ready for review December 19, 2023 11:19
@SagarGi
Copy link
Member Author

SagarGi commented Dec 19, 2023

#8008 can be done once this is approved and merged!

@SagarGi SagarGi force-pushed the sharingAPI/createLink branch from 1bd7908 to b874588 Compare December 20, 2023 03:48
@SagarGi SagarGi force-pushed the sharingAPI/createLink branch from b874588 to cd9a187 Compare December 20, 2023 07:13
@SagarGi SagarGi requested review from grgprarup and saw-jan December 20, 2023 07:13
@SagarGi SagarGi force-pushed the sharingAPI/createLink branch from cd9a187 to b4a1351 Compare December 20, 2023 10:12
saw-jan
saw-jan approved these changes Dec 20, 2023
View reviewed changes
Copy link
Member

@saw-jan saw-jan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@SagarGi SagarGi merged commit 65b8c1a into master Dec 20, 2023
2 checks passed
@delete-merged-branch delete-merged-branch bot deleted the sharingAPI/createLink branch December 20, 2023 11:16
ownclouders pushed a commit that referenced this pull request Dec 20, 2023
@SagarGi
[tests-only][full-ci]Added tests for creating link for a resource (#7982
a3e7ed4 
)

* Added tests for creating link for a resource

* review adress and refactor
2403905 pushed a commit to 2403905/ocis that referenced this pull request Jan 24, 2024
@SagarGi @2403905
[tests-only][full-ci]Added tests for creating link for a resource (ow…
7bbeba8 
…ncloud#7982)

* Added tests for creating link for a resource

* review adress and refactor
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saw-jan saw-jan saw-jan approved these changes

@ScharfViktor ScharfViktor Awaiting requested review from ScharfViktor

@phil-davis phil-davis Awaiting requested review from phil-davis

@SwikritiT SwikritiT Awaiting requested review from SwikritiT

@Salipa-Gurung Salipa-Gurung Awaiting requested review from Salipa-Gurung

@amrita-shrestha amrita-shrestha Awaiting requested review from amrita-shrestha

@nabim777 nabim777 Awaiting requested review from nabim777

@S-Panta S-Panta Awaiting requested review from S-Panta

@nirajacharya2 nirajacharya2 Awaiting requested review from nirajacharya2

@grgprarup grgprarup Awaiting requested review from grgprarup

@PrajwolAmatya PrajwolAmatya Awaiting requested review from PrajwolAmatya

Assignees

@SagarGi SagarGi

Labels
QA:team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@SagarGi @grgprarup @saw-jan @PrajwolAmatya