Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

trash-bin cli has been exteneded by the list and restore commands #7917

Merged
merged 4 commits into from
Dec 19, 2023
Merged

trash-bin cli has been exteneded by the list and restore commands #7917

merged 4 commits into from
Dec 19, 2023

Conversation

2403905
Copy link
Contributor

@2403905 2403905 commented Dec 8, 2023 •
edited
Loading

Description

As an admin of a larger instance I want to be able to help users to restore files from the trashbin of their instance if they can not do it in self service.

For that, a CLI tool would be handsome that is able to

  • list the trashbin content of a certain space
  • restore all files in the space trashbin
  • optional: restore by Id selected files
    The CLI tool could be completely separate from oCIS but should be maintained in the oCIS repo with the main code. A backport to v4 needs to be provided.

Related Issue

  • Fixes <issue_link>

Motivation and Context

How Has This Been Tested?

  • test environment:
  • test case 1:
  • test case 2:
  • ...

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@update-docs Update Docs
Copy link

update-docs bot commented Dec 8, 2023

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@mmattel mmattel mentioned this pull request Dec 11, 2023
Closed
@2403905 2403905 marked this pull request as ready for review December 13, 2023 17:28
@2403905 2403905 enabled auto-merge December 13, 2023 17:31
@2403905 2403905 disabled auto-merge December 13, 2023 17:32
@2403905 2403905 enabled auto-merge (squash) December 13, 2023 17:32
@2403905 2403905 requested a review from kobergj December 13, 2023 17:56
kobergj
kobergj requested changes Dec 14, 2023
View reviewed changes
services/storage-users/pkg/command/trash_bin.go Outdated Show resolved Hide resolved
services/storage-users/pkg/command/trash_bin.go Outdated Show resolved Hide resolved
services/storage-users/pkg/command/trash_bin.go Outdated Show resolved Hide resolved
services/storage-users/pkg/command/trash_bin.go Outdated Show resolved Hide resolved
services/storage-users/pkg/command/trash_bin.go Outdated Show resolved Hide resolved
services/storage-users/pkg/command/trash_bin.go Outdated Show resolved Hide resolved
services/storage-users/pkg/command/trash_bin.go Outdated Show resolved Hide resolved
services/storage-users/pkg/command/trash_bin.go Show resolved Hide resolved
services/storage-users/pkg/command/trash_bin.go Outdated Show resolved Hide resolved
services/storage-users/pkg/command/trash_bin.go Outdated Show resolved Hide resolved
@2403905 2403905 requested a review from kobergj December 14, 2023 14:30
@2403905 2403905 force-pushed the issue-7845 branch 2 times, most recently from f004a85 to 51f4864 Compare December 14, 2023 15:59
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Dec 18, 2023

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

7 New issues
0 Security Hotspots
4.9% Coverage on New Code
10.7% Duplication on New Code

See analysis details on SonarCloud

kobergj
kobergj approved these changes Dec 19, 2023
View reviewed changes
Copy link
Collaborator

@kobergj kobergj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@2403905 2403905 merged commit 367f1ff into owncloud:master Dec 19, 2023
4 checks passed
ownclouders pushed a commit that referenced this pull request Dec 19, 2023
@2403905
trash-bin cli has been exteneded by the list and restore commands (#7917
6974aed 
)

* trash-bin cli has been exteneded by the list and restore commands

* v4 to v5 changes

---------

Co-authored-by: Roman Perekhod <[email protected]>
@micbar micbar mentioned this pull request Dec 20, 2023
Closed
71 tasks
2403905 added a commit to 2403905/ocis that referenced this pull request Jan 24, 2024
@2403905
trash-bin cli has been exteneded by the list and restore commands (ow…
ae4624a 
…ncloud#7917)

* trash-bin cli has been exteneded by the list and restore commands

* v4 to v5 changes

---------

Co-authored-by: Roman Perekhod <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmattel mmattel mmattel left review comments

@kobergj kobergj kobergj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@2403905 @mmattel @kobergj