Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tests-only][full-ci] removing the setResponse() and $this->response in given/then step in Sharing file #7889

Merged
merged 1 commit into from
Dec 11, 2023
Merged

[tests-only][full-ci] removing the setResponse() and $this->response in given/then step in Sharing file #7889

merged 1 commit into from
Dec 11, 2023

Conversation

nirajacharya2
Copy link
Contributor

Description

backport of : #7534

Related Issue

part of: #7082

Motivation and Context

  • To remove setResponse() and $this->response in the Given/Then steps and some helper functions
  • To avoid false positive assertions

How Has This Been Tested?

  • test environment:
  • locally
  • CI

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@nirajacharya2 nirajacharya2 self-assigned this Dec 6, 2023
@nirajacharya2 nirajacharya2 mentioned this pull request Dec 6, 2023
Closed
6 tasks
@nirajacharya2 nirajacharya2 force-pushed the refactor-sharingcontext-bp branch 2 times, most recently from c0ac00c to fa55118 Compare December 6, 2023 09:51
@nirajacharya2 nirajacharya2 force-pushed the refactor-sharingcontext-bp branch from fa55118 to ab945b0 Compare December 8, 2023 06:08
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Dec 8, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@nirajacharya2 nirajacharya2 marked this pull request as ready for review December 8, 2023 11:01
@saw-jan saw-jan merged commit b7bba06 into stable-4.0 Dec 11, 2023
3 checks passed
@delete-merged-branch delete-merged-branch bot deleted the refactor-sharingcontext-bp branch December 11, 2023 07:24
ownclouders pushed a commit that referenced this pull request Dec 11, 2023
@nirajacharya2
refactoring Sharing.php test file (#7889)
a066998
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saw-jan saw-jan saw-jan approved these changes

@phil-davis phil-davis phil-davis approved these changes

@SwikritiT SwikritiT Awaiting requested review from SwikritiT

@SagarGi SagarGi Awaiting requested review from SagarGi

@amrita-shrestha amrita-shrestha Awaiting requested review from amrita-shrestha

@nabim777 nabim777 Awaiting requested review from nabim777

@S-Panta S-Panta Awaiting requested review from S-Panta

@PrajwolAmatya PrajwolAmatya Awaiting requested review from PrajwolAmatya

Assignees

@nirajacharya2 nirajacharya2

Labels
QA:team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nirajacharya2 @phil-davis @saw-jan