Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tests-only][full-ci] removing the setResponse() and $this->response in given/then step in Provisioning file #7811

Merged
merged 1 commit into from
Dec 1, 2023
Merged

[tests-only][full-ci] removing the setResponse() and $this->response in given/then step in Provisioning file #7811

merged 1 commit into from
Dec 1, 2023

Conversation

nirajacharya2
Copy link
Contributor

Description

We have used setResponse() and $this->response in the Given/Then steps and some helper functions (maybe to reuse existing available methods). But storing responses from Given/Then steps and helper functions is not a good idea because it can lead to a false positive assertion in the Then steps.
So, check the use of setResponse() and $this->response in

  • Given steps
  • Then steps (Then steps can use $this->response but must prevent saving to it)
  • Helper functions

So this pr make the above changes in Provisioning.php

Related Issue

part of: #7082

Motivation and Context

  • To remove setResponse() and $this->response in the Given/Then steps and some helper functions
  • To avoid false positive assertions

How Has This Been Tested?

  • test environment:
  • locally
  • CI

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@nirajacharya2 nirajacharya2 mentioned this pull request Nov 27, 2023
Closed
6 tasks
@nirajacharya2 nirajacharya2 force-pushed the refactor-provisioning-context branch 3 times, most recently from c76289c to 8b95333 Compare November 28, 2023 03:23
@nirajacharya2 nirajacharya2 force-pushed the refactor-provisioning-context branch 2 times, most recently from c495ce2 to bce97b3 Compare November 28, 2023 06:55
@nirajacharya2 nirajacharya2 force-pushed the refactor-provisioning-context branch from bce97b3 to 86ab832 Compare November 28, 2023 08:54
@nirajacharya2 nirajacharya2 marked this pull request as ready for review November 28, 2023 08:55
@nirajacharya2 nirajacharya2 force-pushed the refactor-provisioning-context branch from 86ab832 to 446c477 Compare November 28, 2023 09:40
SagarGi
SagarGi reviewed Nov 29, 2023
View reviewed changes
Copy link
Member

@SagarGi SagarGi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Refactor LGTM 👍

@nirajacharya2 nirajacharya2 force-pushed the refactor-provisioning-context branch 3 times, most recently from 297ad04 to e35139c Compare November 29, 2023 06:31
PrajwolAmatya
PrajwolAmatya reviewed Nov 29, 2023
View reviewed changes
Copy link
Contributor

@PrajwolAmatya PrajwolAmatya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@nirajacharya2 nirajacharya2 force-pushed the refactor-provisioning-context branch from e35139c to bfae320 Compare November 29, 2023 06:35
@nirajacharya2 nirajacharya2 force-pushed the refactor-provisioning-context branch from bfae320 to 5efcd55 Compare November 30, 2023 09:35
@sonarqubecloud SonarQubeCloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

saw-jan
saw-jan approved these changes Dec 1, 2023
View reviewed changes
Copy link
Member

@saw-jan saw-jan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@saw-jan saw-jan merged commit 26411f1 into master Dec 1, 2023
4 checks passed
@delete-merged-branch delete-merged-branch bot deleted the refactor-provisioning-context branch December 1, 2023 08:17
ownclouders pushed a commit that referenced this pull request Dec 1, 2023
@nirajacharya2 @nabim777
re runing ci (#7811)
a4acb8c 
Co-authored-by: Nalem7 <[email protected]>
@nirajacharya2 nirajacharya2 mentioned this pull request Dec 1, 2023
Merged
9 tasks
2403905 pushed a commit to 2403905/ocis that referenced this pull request Dec 8, 2023
@nirajacharya2 @nabim777 @2403905
re runing ci (owncloud#7811)
631a950 
Co-authored-by: Nalem7 <[email protected]>
2403905 pushed a commit to 2403905/ocis that referenced this pull request Jan 24, 2024
@nirajacharya2 @nabim777 @2403905
re runing ci (owncloud#7811)
e345f9f 
Co-authored-by: Nalem7 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saw-jan saw-jan saw-jan approved these changes

@phil-davis phil-davis Awaiting requested review from phil-davis

@SwikritiT SwikritiT Awaiting requested review from SwikritiT

@amrita-shrestha amrita-shrestha Awaiting requested review from amrita-shrestha

@nabim777 nabim777 Awaiting requested review from nabim777

@S-Panta S-Panta Awaiting requested review from S-Panta

@PrajwolAmatya PrajwolAmatya Awaiting requested review from PrajwolAmatya

@SagarGi SagarGi Awaiting requested review from SagarGi

Assignees

@nirajacharya2 nirajacharya2

Labels
QA:team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@nirajacharya2 @SagarGi @saw-jan @PrajwolAmatya @nabim777