Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tests-only][full-ci] move tests coreApiWebdavLocksUnlock/unlockSharingToShares.feature from to local api #7769

Merged
merged 2 commits into from
Nov 21, 2023
Merged

[tests-only][full-ci] move tests coreApiWebdavLocksUnlock/unlockSharingToShares.feature from to local api #7769

merged 2 commits into from
Nov 21, 2023

Conversation

SwikritiT
Copy link
Contributor

Description

move tests coreApiWebdavLocksUnlock/unlockSharingToShares.feature from to local api

Related Issue

Motivation and Context

How Has This Been Tested?

  • local
  • CI

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@SwikritiT SwikritiT self-assigned this Nov 21, 2023
@SwikritiT SwikritiT changed the title [tests-only][full-ci] tests:move tests coreApiWebdavLocksUnlock/unlockSharingToShares.feature from to local api [tests-only][full-ci] move tests coreApiWebdavLocksUnlock/unlockSharingToShares.feature from to local api Nov 21, 2023
@SwikritiT SwikritiT force-pushed the tests/move-unlock-related-tests-related-to-shares branch from d8a3b08 to baaea7e Compare November 21, 2023 10:09
@SwikritiT SwikritiT mentioned this pull request Nov 21, 2023
Closed
7 tasks
@SwikritiT SwikritiT marked this pull request as ready for review November 21, 2023 10:25
ScharfViktor
ScharfViktor reviewed Nov 21, 2023
View reviewed changes
Copy link
Contributor

@ScharfViktor ScharfViktor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can delete folder coreApiWebdavLocksUnlock and delete from behat config

@SwikritiT
Copy link
Contributor Author

we can delete folder coreApiWebdavLocksUnlock and delete from behat config

I've deleted coreApiWebdavLocksUnlock I'll also remove the behat config. Thanks for the reminder!

@SwikritiT SwikritiT force-pushed the tests/move-unlock-related-tests-related-to-shares branch from baaea7e to 699b960 Compare November 21, 2023 11:17
@sonarqubecloud SonarQubeCloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@saw-jan saw-jan merged commit 279d0f8 into master Nov 21, 2023
2 checks passed
@delete-merged-branch delete-merged-branch bot deleted the tests/move-unlock-related-tests-related-to-shares branch November 21, 2023 12:00
ownclouders pushed a commit that referenced this pull request Nov 21, 2023
@SwikritiT
[tests-only][full-ci] move tests `coreApiWebdavLocksUnlock/unlockShar…
05a91e9 
…ingToShares.feature` from to local api (#7769)

* tests:move tests from coreApiWebdavLocksUnlock/unlockSharingToShares.feature to local api

* tests: remove unnecessary behat config
Sky2533k
Sky2533k reviewed Nov 27, 2023
View reviewed changes
Copy link

@Sky2533k Sky2533k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tests/acceptance/config/behat-core.yml

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sky2533k Sky2533k Sky2533k left review comments

@saw-jan saw-jan saw-jan approved these changes

@grgprarup grgprarup grgprarup approved these changes

@amrita-shrestha amrita-shrestha Awaiting requested review from amrita-shrestha

@nabim777 nabim777 Awaiting requested review from nabim777

@PrajwolAmatya PrajwolAmatya Awaiting requested review from PrajwolAmatya

@SagarGi SagarGi Awaiting requested review from SagarGi

@ScharfViktor ScharfViktor Awaiting requested review from ScharfViktor

Assignees

@SwikritiT SwikritiT

Labels
QA:team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@SwikritiT @grgprarup @saw-jan @ScharfViktor @Sky2533k