Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add more accepted languages #7754

Merged
merged 1 commit into from
Nov 22, 2023
Merged

feat: add more accepted languages #7754

merged 1 commit into from
Nov 22, 2023

Conversation

kulmann
Copy link
Member

@kulmann kulmann commented Nov 20, 2023

Description

This PR adds languages to the list of accepted languages which have 70% or more translation coverage in transifex + Swedish by request of a community member who promised to help with translations, see owncloud/web#10007

The reason for this change is that the settings services only persists language codes which are known in the definition of the setting. The user facing changes (available languages in the dropdown of the account page) will happen in web only. Hence I didn't include a changelog item, yet. Will be part of the next web bump then.

Related Issue

Motivation and Context

Make community happy.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@kulmann kulmann requested a review from lookacat as a code owner November 20, 2023 05:41
Copy link

update-docs bot commented Nov 20, 2023

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@kulmann kulmann requested review from micbar and 2403905 November 20, 2023 05:41
@kulmann kulmann self-assigned this Nov 20, 2023
Adding languages to the list of accepted languages which have 70% or
more translation coverage in transifex + swedish by request of a
community member who promised to help with translations.
Copy link

sonarcloud bot commented Nov 21, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
50.0% 50.0% Duplication

Copy link
Contributor

@JammingBen JammingBen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Is it worth adding a changelog item?

@kulmann
Copy link
Member Author

kulmann commented Nov 21, 2023

LGTM. Is it worth adding a changelog item?

IMO no. see PR description 😁 The user facing changes (available languages in the dropdown of the account page) will happen in web only. Hence I didn't include a changelog item, yet. Will be part of the next web bump then.

@kulmann kulmann merged commit 5b549d1 into master Nov 22, 2023
2 checks passed
@delete-merged-branch delete-merged-branch bot deleted the add-languages branch November 22, 2023 05:49
ownclouders pushed a commit that referenced this pull request Nov 22, 2023
feat: add more accepted languages
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants