Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[full-ci] web bump. fix flaky e2e test. #7748

Merged
merged 4 commits into from
Nov 20, 2023
Merged

[full-ci] web bump. fix flaky e2e test. #7748

merged 4 commits into from
Nov 20, 2023

Conversation

ScharfViktor
Copy link
Contributor

@ScharfViktor ScharfViktor commented Nov 17, 2023

Copy link

update-docs bot commented Nov 17, 2023

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@ScharfViktor
Copy link
Contributor Author

ScharfViktor commented Nov 17, 2023

It seams that v8.0.0-alpha.8 doesn't have this one owncloud/web#9931 so e2e internal link test fails
@JammingBen that means I need new web release?

@JammingBen
Copy link
Contributor

@JammingBen that means I need new web release?

Yes exactly. I can create one now if you want?

@ScharfViktor
Copy link
Contributor Author

Yes exactly. I can create one now if you want?

That would be great and would help make our CI happy

@JammingBen JammingBen requested a review from kulmann as a code owner November 17, 2023 14:15
@JammingBen
Copy link
Contributor

@ScharfViktor I bumped Web and the commit id, let's see. If it still fails, something is probably still flaky...

@ScharfViktor
Copy link
Contributor Author

@JammingBen thank you 👍

@ScharfViktor
Copy link
Contributor Author

let's see. If it still fails, something is probably still flaky...

all of e2e passed on the first try except of this: quick fix: owncloud/web#9986

@micbar micbar enabled auto-merge November 17, 2023 20:15
Copy link

sonarcloud bot commented Nov 20, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@@ -2,3 +2,4 @@ password
12345678
123
ownCloud
ownCloud-1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: this needs to be added because it was added to the web tests by PR owncloud/web#9948
And so when running the web tests in cis, a similar banned-password-list is needed.

@micbar micbar merged commit c541c52 into master Nov 20, 2023
2 checks passed
@delete-merged-branch delete-merged-branch bot deleted the updateWeb branch November 20, 2023 07:25
ownclouders pushed a commit that referenced this pull request Nov 20, 2023
[full-ci] web bump. fix flaky e2e test.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[QA] Flaky public-link e2e test Flaky e2e tests. opening public link
4 participants