Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[full-ci] Enhancement(sharing-ng): add invitation graph beta api #7687

Merged
merged 1 commit into from
Nov 17, 2023
Merged

[full-ci] Enhancement(sharing-ng): add invitation graph beta api #7687

merged 1 commit into from
Nov 17, 2023

Conversation

fschade
Copy link
Contributor

@fschade fschade commented Nov 8, 2023 •
edited
Loading

Description

Add the ability to create share invitations via the graph api.

Related Issue

Motivation and Context

complete the ADR and be able to use sharing ng as designed.

How Has This Been Tested?

  • unit tests
  • manual testing

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@fschade fschade mentioned this pull request Nov 8, 2023
Open
22 tasks
@fschade fschade force-pushed the graph-beta-drive-invite-api branch from 5cce604 to 9f22aca Compare November 9, 2023 08:19
rhafer
rhafer suggested changes Nov 14, 2023
View reviewed changes
Copy link
Contributor

@rhafer rhafer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't do a full review yet. Just noticed a small thing when trying to steal from your code 😃

services/graph/pkg/service/v0/driveitems.go Outdated Show resolved Hide resolved
@fschade fschade force-pushed the graph-beta-drive-invite-api branch 2 times, most recently from 5c2a85f to d533a70 Compare November 15, 2023 13:15
@fschade fschade marked this pull request as ready for review November 15, 2023 13:40
@fschade fschade changed the title Enhancement(sharing-ng): add invitation graph beta api [full-ci] Enhancement(sharing-ng): add invitation graph beta api Nov 16, 2023
@fschade fschade force-pushed the graph-beta-drive-invite-api branch 3 times, most recently from b3cd000 to 86c2bac Compare November 16, 2023 16:55
@individual-it individual-it mentioned this pull request Nov 17, 2023
Merged
@fschade fschade force-pushed the graph-beta-drive-invite-api branch 3 times, most recently from 6806dff to 939aadb Compare November 17, 2023 13:30
@fschade fschade force-pushed the graph-beta-drive-invite-api branch from 939aadb to 87d3523 Compare November 17, 2023 14:35
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 17, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 3 Code Smells

87.6% 87.6% Coverage
0.0% 0.0% Duplication

@fschade fschade merged commit ad57d59 into owncloud:master Nov 17, 2023
2 checks passed
ownclouders pushed a commit that referenced this pull request Nov 17, 2023
@fschade
enhancement: add graph invite endpoint (#7687)
f342a18
This was referenced Nov 18, 2023
Merged
Merged
This was referenced Nov 30, 2023
Merged
Merged
@micbar micbar mentioned this pull request Dec 12, 2023
Merged
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rhafer rhafer rhafer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fschade @rhafer