Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs-only][ADR] Index and store metadata #7515

Merged
merged 6 commits into from
Oct 19, 2023
Merged

[docs-only][ADR] Index and store metadata #7515

merged 6 commits into from
Oct 19, 2023

Conversation

dschmidt
Copy link
Member

@dschmidt dschmidt commented Oct 17, 2023 •
edited
Loading

Rendered

See also #7490

@update-docs
Copy link

update-docs bot commented Oct 17, 2023

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@dschmidt dschmidt requested review from butonic and micbar October 17, 2023 16:34
micbar
micbar approved these changes Oct 18, 2023
View reviewed changes
Copy link
Contributor

@micbar micbar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Like it! The decision drivers are good.

@dschmidt dschmidt changed the title [ADR] Index and store metadata [docs-only][ADR] Index and store metadata Oct 18, 2023
dragotin
dragotin approved these changes Oct 18, 2023
View reviewed changes
docs/ocis/adr/0023-index-and-store-metadata.md Outdated Show resolved Hide resolved
@mmattel
Copy link
Contributor

mmattel commented Oct 19, 2023

Just some small text improvements like consistently use Headline Capitalisation etc.

@dschmidt dschmidt enabled auto-merge (squash) October 19, 2023 08:07
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@dschmidt dschmidt merged commit fbfb1a0 into master Oct 19, 2023
1 of 2 checks passed
@delete-merged-branch delete-merged-branch bot deleted the adr-metadata branch October 19, 2023 08:12
ownclouders pushed a commit that referenced this pull request Oct 19, 2023
@dschmidt
[docs-only][ADR] Index and store metadata (#7515)
52a0621
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@micbar micbar micbar approved these changes

@mmattel mmattel mmattel left review comments

@dragotin dragotin dragotin approved these changes

@butonic butonic Awaiting requested review from butonic

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dschmidt @mmattel @dragotin @micbar