[tests-only][full-ci] removing the setResponse() and $this->response in given/then step in Provisioning file
#7510
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
6 tasks
nirajacharya2
force-pushed
the
refactor-provisioning
branch
4 times, most recently
from
bfae1e5 to
a770b07
Compare
nirajacharya2
force-pushed
the
refactor-provisioning
branch
6 times, most recently
from
49f077d to
f7a8a62
Compare
nirajacharya2
force-pushed
the
refactor-provisioning
branch
3 times, most recently
from
2c46b2b to
0fbb7e4
Compare
nirajacharya2
force-pushed
the
refactor-provisioning
branch
4 times, most recently
from
aae0217 to
573119d
Compare
nirajacharya2
requested review from
phil-davis,
grgprarup,
SwikritiT,
SagarGi,
saw-jan,
amrita-shrestha,
nabim777,
S-Panta and
PrajwolAmatya
S-Panta
reviewed
Nov 10, 2023
nirajacharya2
force-pushed
the
refactor-provisioning
branch
from
573119d to
fc862cc
Compare
nirajacharya2
force-pushed
the
refactor-provisioning
branch
from
fc862cc to
f793d59
Compare
saw-jan
reviewed
Nov 21, 2023
Comment on lines
3485
to
3531
| /** | ||
| * @param string $user | ||
| * | ||
| * @return ResponseInterface | ||
| * @throws Exception | ||
| */ | ||
| public function deleteTheUserUsingTheProvisioningApi(string $user):ResponseInterface { | ||
| $this->emptyLastHTTPStatusCodesArray(); | ||
| $this->emptyLastOCSStatusCodesArray(); | ||
| $response = null; | ||
| // Always try to delete the user | ||
| if (OcisHelper::isTestingWithGraphApi()) { | ||
| // users can be deleted using the username in the GraphApi too | ||
| $response = $this->graphContext->adminDeletesUserUsingTheGraphApi($user); | ||
| } else { | ||
| $response = UserHelper::deleteUser( | ||
| $this->getBaseUrl(), | ||
| $user, | ||
| $this->getAdminUsername(), | ||
| $this->getAdminPassword(), | ||
| $this->getStepLineRef(), | ||
| $this->ocsApiVersion | ||
| ); | ||
| } | ||
| if ($response === null) { | ||
| $this->pushToLastStatusCodesArrays(); | ||
| } else { | ||
| $this->pushToLastHttpStatusCodesArray((string)$response->getStatusCode()); | ||
| } | ||
|
|
||
| // Only log a message if the test really expected the user to have been | ||
| // successfully created (i.e. the delete is expected to work) and | ||
| // there was a problem deleting the user. Because in this case there | ||
| // might be an effect on later tests. | ||
| if ($this->theUserShouldExist($user) | ||
| && (!\in_array($response->getStatusCode(), [200, 204])) | ||
| ) { | ||
| \error_log( | ||
| "INFORMATION: could not delete user '$user' " | ||
| . $response->getStatusCode() . " " . $response->getBody() | ||
| ); | ||
| } | ||
|
|
||
| $this->rememberThatUserIsNotExpectedToExist($user); | ||
| return $response; | ||
| } | ||
|
|
saw-jan
reviewed
Nov 21, 2023
Comment on lines
4187
to
4189
| public function theUsersReturnedByTheApiShouldNotInclude(string $user, ResponseInterface $response):void { | ||
| $response = $response ?? $this->response; | ||
| $respondedArray = $this->getArrayOfUsersResponded($response); |
There was a problem hiding this comment.
let's not reuse Then step methods
saw-jan
reviewed
Nov 21, 2023
Comment on lines
4346
to
4347
| public function theDisplayNameReturnedByTheApiShouldBe(string $expectedDisplayName, ?ResponseInterface $response = null):void { | ||
| $responseDisplayName = (string) $this->getResponseXml($response, __METHOD__)->data[0]->displayname; |
nirajacharya2
force-pushed
the
refactor-provisioning
branch
from
f793d59 to
bad274b
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We have used setResponse() and $this->response in the Given/Then steps and some helper functions (maybe to reuse existing available methods). But storing responses from Given/Then steps and helper functions is not a good idea because it can lead to a false positive assertion in the Then steps.
So, check the use of setResponse() and $this->response in
So this pr make the above changes in
Provisioning.phpRelated Issue
part of: #7082
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: