-
Notifications
You must be signed in to change notification settings - Fork 187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[tests-only] [full-ci] removing the setresponse in given/then step in spaces context #7496
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KarunAtreya
force-pushed
the
refactor_spaces_context
branch
from
October 16, 2023 09:48
22c1ca0
to
54b0445
Compare
KarunAtreya
requested review from
grgprarup,
SwikritiT,
saw-jan,
amrita-shrestha,
nabim777,
S-Panta,
PrajwolAmatya and
nirajacharya2
October 16, 2023 11:35
Closed
6 tasks
saw-jan
reviewed
Oct 17, 2023
saw-jan
reviewed
Oct 17, 2023
saw-jan
reviewed
Oct 17, 2023
saw-jan
reviewed
Oct 17, 2023
saw-jan
reviewed
Oct 17, 2023
saw-jan
reviewed
Oct 17, 2023
saw-jan
reviewed
Oct 17, 2023
saw-jan
reviewed
Oct 17, 2023
saw-jan
reviewed
Oct 17, 2023
saw-jan
reviewed
Oct 17, 2023
saw-jan
reviewed
Oct 17, 2023
saw-jan
reviewed
Oct 17, 2023
saw-jan
reviewed
Oct 17, 2023
saw-jan
reviewed
Oct 17, 2023
saw-jan
approved these changes
Oct 17, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Kudos, SonarCloud Quality Gate passed! |
ownclouders
pushed a commit
that referenced
this pull request
Oct 17, 2023
… spaces context (#7496) * refactor given/when/then steps in spaces context * pass the returned response without setting in then step * added the missing when step whose response is checked by the then step * addressed the reviews * changed from decoded body to docoded response
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We have used setResponse() and $this->response in the Given/Then steps and some helper functions (maybe to reuse existing available methods). But storing responses from Given/Then steps and helper functions is not a good idea because it can lead to a false positive assertion in the Then steps.
So, check the use of setResponse() and $this->response in
So this pr make the above changes in
SpacesContext
Related Issue
#7082
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: