[tests-only][full-ci] Backport refactoring webdav context removing setresponse() in given/then step #7480
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
refactoring the given steps in the webdav context refactored remaining given/when/then steps return file id trim trailing from the folder path add missing when step and make other minor corrections set responseXml and correct status code check correct the naming of steps and helper functions
KarunAtreya
requested review from
grgprarup,
SwikritiT,
saw-jan,
amrita-shrestha and
PrajwolAmatya
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
KarunAtreya
changed the title
KarunAtreya
changed the title
Closed
6 tasks
KarunAtreya
force-pushed
the
backport_refactor_webdav_context
branch
from
e7d8fcb to
a42cacb
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
grgprarup
approved these changes
Oct 13, 2023
saw-jan
approved these changes
Oct 13, 2023
ownclouders
pushed a commit
that referenced
this pull request
Oct 13, 2023
…tresponse() in given/then step (#7480) * refactoring webdav context (setting response in when step only) refactoring the given steps in the webdav context refactored remaining given/when/then steps return file id trim trailing from the folder path add missing when step and make other minor corrections set responseXml and correct status code check correct the naming of steps and helper functions * setting response
ownclouders
pushed a commit
that referenced
this pull request
Oct 14, 2023
…tresponse() in given/then step (#7480) * refactoring webdav context (setting response in when step only) refactoring the given steps in the webdav context refactored remaining given/when/then steps return file id trim trailing from the folder path add missing when step and make other minor corrections set responseXml and correct status code check correct the naming of steps and helper functions * setting response
ownclouders
pushed a commit
that referenced
this pull request
Oct 16, 2023
…tresponse() in given/then step (#7480) * refactoring webdav context (setting response in when step only) refactoring the given steps in the webdav context refactored remaining given/when/then steps return file id trim trailing from the folder path add missing when step and make other minor corrections set responseXml and correct status code check correct the naming of steps and helper functions * setting response
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pr backports #7403 from master to stable-4.0