[tests-only] [full-ci] removing the setresponse in given/then step in spacestus context #7447
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KarunAtreya
force-pushed
the
refactor_spacestus_context
branch
from
6892dbe to
065c9fb
Compare
KarunAtreya
requested review from
grgprarup,
SwikritiT,
SagarGi,
saw-jan,
Salipa-Gurung,
nabim777,
S-Panta,
PrajwolAmatya and
nirajacharya2
Closed
6 tasks
KarunAtreya
force-pushed
the
refactor_spacestus_context
branch
2 times, most recently
from
1c56a33 to
19f9d59
Compare
saw-jan
reviewed
Oct 11, 2023
KarunAtreya
force-pushed
the
refactor_spacestus_context
branch
2 times, most recently
from
70a976f to
52eabfd
Compare
grgprarup
reviewed
Oct 12, 2023
grgprarup
reviewed
Oct 12, 2023
grgprarup
approved these changes
Oct 12, 2023
KarunAtreya
force-pushed
the
refactor_spacestus_context
branch
from
52eabfd to
19cc882
Compare
KarunAtreya
force-pushed
the
refactor_spacestus_context
branch
from
19cc882 to
622b8aa
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
saw-jan
approved these changes
Oct 12, 2023
ownclouders
pushed a commit
that referenced
this pull request
Oct 12, 2023
… spacestus context (#7447) * refactored removing setting response in given/then steps in spacetus context * adressing reviews
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We have used setResponse() and $this->response in the Given/Then steps and some helper functions (maybe to reuse existing available methods). But storing responses from Given/Then steps and helper functions is not a good idea because it can lead to a false positive assertion in the Then steps.
So, check the use of setResponse() and $this->response in
So this pr make the above changes in
SpacesTusContextRelated Issue
#7082
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: