[tests-only] removing the setresponse in given/when/then step in ocs and webdavlocking context #7347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KarunAtreya
force-pushed
the
refactor_ocsContext_webdavlockingContext
branch
3 times, most recently
from
b10824d to
8d2ddbf
Compare
Closed
6 tasks
KarunAtreya
force-pushed
the
refactor_ocsContext_webdavlockingContext
branch
2 times, most recently
from
567ae26 to
4809191
Compare
KarunAtreya
requested review from
saw-jan,
amrita-shrestha,
grgprarup,
SwikritiT,
SagarGi,
Salipa-Gurung,
nabim777,
S-Panta,
PrajwolAmatya and
nirajacharya2
saw-jan
reviewed
Sep 29, 2023
KarunAtreya
force-pushed
the
refactor_ocsContext_webdavlockingContext
branch
from
645a0f2 to
f5b0928
Compare
KarunAtreya
force-pushed
the
refactor_ocsContext_webdavlockingContext
branch
from
f5b0928 to
8efeab3
Compare
KarunAtreya
changed the title
KarunAtreya
force-pushed
the
refactor_ocsContext_webdavlockingContext
branch
from
8efeab3 to
037ed09
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
delete-merged-branch
bot
deleted the
refactor_ocsContext_webdavlockingContext
branch
ownclouders
pushed a commit
that referenced
this pull request
Oct 2, 2023
…and webdavlocking context (#7347) * refactor given and when steps in ocs and webdav locking context * use the returned response * use of returned response from helper function * made changes to the affected test steps * deleted vardump line
ownclouders
pushed a commit
that referenced
this pull request
Oct 3, 2023
…and webdavlocking context (#7347) * refactor given and when steps in ocs and webdav locking context * use the returned response * use of returned response from helper function * made changes to the affected test steps * deleted vardump line
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We have used setResponse() and $this->response in the Given/Then steps and some helper functions (maybe to reuse existing available methods). But storing responses from Given/Then steps and helper functions is not a good idea because it can lead to a false positive assertion in the Then steps.
So, check the use of setResponse() and $this->response in
So this pr make the above changes in
OCSContextandWebDavLockingContextRelated Issue
#7082
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: