Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tests-only][full-ci]Added test for the propfind with file-id #7335

Merged
merged 3 commits into from
Sep 26, 2023
Merged

[tests-only][full-ci]Added test for the propfind with file-id #7335

merged 3 commits into from
Sep 26, 2023

Conversation

SagarGi
Copy link
Member

@SagarGi SagarGi commented Sep 22, 2023

Description

This PR adds tests for the PROPFIND request to a file not by its name but by its file-id in the spaces dav-path-url.

Related Issue:

#6737

@SagarGi SagarGi self-assigned this Sep 22, 2023
@SagarGi SagarGi mentioned this pull request Sep 22, 2023
Closed
5 tasks
@SagarGi SagarGi marked this pull request as ready for review September 22, 2023 07:08
saw-jan
saw-jan reviewed Sep 25, 2023
View reviewed changes
tests/acceptance/features/apiSpacesDavOperation/propfindByFileId.feature Outdated Show resolved Hide resolved
tests/acceptance/features/apiSpacesDavOperation/propfindByFileId.feature Outdated Show resolved Hide resolved
tests/acceptance/features/apiSpacesDavOperation/propfindByFileId.feature Outdated Show resolved Hide resolved
tests/acceptance/features/apiSpacesDavOperation/propfindByFileId.feature Outdated Show resolved Hide resolved
tests/acceptance/features/apiSpacesDavOperation/propfindByFileId.feature Outdated Show resolved Hide resolved
tests/acceptance/features/apiSpacesDavOperation/propfindByFileId.feature Outdated Show resolved Hide resolved
tests/acceptance/features/apiSpacesDavOperation/propfindByFileId.feature Outdated Show resolved Hide resolved
saw-jan
saw-jan approved these changes Sep 25, 2023
View reviewed changes
Copy link
Member

@saw-jan saw-jan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 ✨

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@saw-jan saw-jan merged commit 98b4d3e into master Sep 26, 2023
2 checks passed
@delete-merged-branch delete-merged-branch bot deleted the propfind_by_id branch September 26, 2023 12:20
ownclouders pushed a commit that referenced this pull request Sep 26, 2023
@SagarGi
[tests-only][full-ci]Added test for the propfind with file-id (#7335
4d2364e 
)

* Added test for the propfind with file id

* Refactor the scenario title description

* Review address- refactor scenarios
@SagarGi SagarGi mentioned this pull request Sep 27, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saw-jan saw-jan saw-jan approved these changes

@phil-davis phil-davis Awaiting requested review from phil-davis

@grgprarup grgprarup Awaiting requested review from grgprarup

@KarunAtreya KarunAtreya Awaiting requested review from KarunAtreya

@SwikritiT SwikritiT Awaiting requested review from SwikritiT

@amrita-shrestha amrita-shrestha Awaiting requested review from amrita-shrestha

@nabim777 nabim777 Awaiting requested review from nabim777

@PrajwolAmatya PrajwolAmatya Awaiting requested review from PrajwolAmatya

@ScharfViktor ScharfViktor Awaiting requested review from ScharfViktor

Assignees

@SagarGi SagarGi

Labels
QA:team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SagarGi @saw-jan