[tests-only][full-ci] removing the setresponse in given/then step in AppConfigurationContext and AuthContext #7186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KarunAtreya
requested review from
saw-jan,
grgprarup,
SwikritiT,
SagarGi,
PrajwolAmatya,
amrita-shrestha and
nabim777
and removed request for
saw-jan
KarunAtreya
force-pushed
the
refactor_giventhen_steps
branch
from
c00a80f to
0f42e78
Compare
SagarGi
reviewed
Sep 4, 2023
KarunAtreya
changed the title
Closed
6 tasks
saw-jan
reviewed
Sep 5, 2023
| @@ -884,11 +887,12 @@ public function administratorRequestsURLWithUsingBasicAuth(string $url, string $ | |||
| */ | |||
| public function userRequestsURLWithUsingBasicTokenAuth(string $user, string $url, string $method):void { | |||
There was a problem hiding this comment.
NOTE: This function is used in the Given steps below which should be prevented. But do it in the next iteration. See the second point todo list (#7082). First, fix all setResponse usage and then check the reuse of step-def functions in other steps and refactor it.
SwikritiT
reviewed
Sep 5, 2023
tests/acceptance/features/bootstrap/AppConfigurationContext.php
Outdated
Show resolved
Hide resolved
SwikritiT
reviewed
Sep 5, 2023
tests/acceptance/features/bootstrap/AppConfigurationContext.php
Outdated
Show resolved
Hide resolved
KarunAtreya
force-pushed
the
refactor_giventhen_steps
branch
2 times, most recently
from
1ab7697 to
f0608fb
Compare
SwikritiT
reviewed
Sep 6, 2023
KarunAtreya
force-pushed
the
refactor_giventhen_steps
branch
from
f0608fb to
14c5f61
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
ownclouders
pushed a commit
that referenced
this pull request
Sep 6, 2023
…AppConfigurationContext and AuthContext (#7186) * removing setting response in the given steps * use response interface * use the returned response * check success response * changed to inline variable * changed variable response_xml to responseXml
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We have used setResponse() and $this->response in the Given/Then steps and some helper functions (maybe to reuse existing available methods). But storing responses from Given/Then steps and helper functions is not a good idea because it can lead to a false positive assertion in the Then steps.
So, check the use of setResponse() and $this->response in
So this pr make the above changes in
AppConfigurationContextandArchiverContextRelated Issue
#7082
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: