-
Notifications
You must be signed in to change notification settings - Fork 188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[tests-only][full-ci]send X-Request-Id in header of every request #7085
Conversation
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
66d85db
to
63a022f
Compare
63a022f
to
3d5b0c2
Compare
128f7cb
to
ef50944
Compare
Please, add the example log in the PR description from the oCIS server logs which contain the requiest-id defined by the tests |
86a15c4
to
02d1b7a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other LGTM 👍
02d1b7a
to
a40bc98
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
a40bc98
to
79881f0
Compare
Kudos, SonarCloud Quality Gate passed! |
Description
This PR includes the use of
X-Request-Id
header in each API requests. TheX-Request-Id
header consists the line reference of the scenario under test. If any of the test fails then oCIS server will log the error which containsrequest-id
which represents the line reference of the failed scenario. For example, when any of the test fails oCIS server will provide the log as:{"level":"error","service":"ocdav","name":"com.owncloud.web.ocdav","traceid":"00000000000000000000000000000000","request-id":"apiContract/propfind.feature:16-18","spaceid":"a428260f-6f47-4e9d-a939-6236977c3f8a$bbac7138-4375-4c27-8241-7ebe1e5af89d","path":"/","status":{"code":15,"message":"error getting upload id: Decomposedfs: error walking path: Decomposedfs: error walking path: decomposedfs: Wrap: readlink error: readlink /home/prajwol/.ocis/storage/users/spaces/bb/ac7138-4375-4c27-8241-7ebe1e5af89d/nodes/bb/ac/71/38/-4375-4c27-8241-7ebe1e5af89d: invalid argument","trace":"00000000000000000000000000000000"},"code":500,"time":"2023-09-05T15:14:31.495096701+05:45","message":"Internal Server Error"}
The server log consists of
"request-id":"apiContract/propfind.feature:16-18"
, which indicates theapiContract
test suite,propfind
feature, the scenario at line16
and the test step at line18
has failed. Using this server information tracking of the failed scenario and its step will be easier.Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: