Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tests-only][full-ci] adding test for deprovisioning notification using different date format #7065

Merged
merged 1 commit into from
Aug 18, 2023
Merged

[tests-only][full-ci] adding test for deprovisioning notification using different date format #7065

merged 1 commit into from
Aug 18, 2023

Conversation

nirajacharya2
Copy link
Contributor

Description

added two scenarios for deprovisioning notification
Scenario: administrator creates a deprovisioning notification with diffrent date format
Scenario: administrator change a deprovisioning notification with diffrent date format

Related Issue

Motivation and Context

How Has This Been Tested?

  • test environment:
  • test case 1:
  • test case 2:
  • ...

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@phil-davis phil-davis changed the title [tests-only][full-ci] adding test for deprovisioning notification using diffrent date format [tests-only][full-ci] adding test for deprovisioning notification using different date format Aug 18, 2023
nirajacharya2
nirajacharya2 commented Aug 18, 2023
View reviewed changes
tests/acceptance/features/apiNotification/deprovisioningNotification.feature Outdated
| deprovision_date | deprovision_date_format |
| 2006-01-02T15:04:05.999999999+07:00 | 2006-01-02T15:04:05.999999999Z07:00 |
| 3:04PM | 3:04PM |
| Jan 2 15:04:05 | Jan _2 15:04:05 |
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

when we make an api request using date format like Jan _2 15:04:05 the server removes the _ with a space so i added a space few places to make assertions.

@nirajacharya2 nirajacharya2 force-pushed the notification-date-format branch 2 times, most recently from 1a0648a to 5f7b9fe Compare August 18, 2023 04:43
@nirajacharya2 nirajacharya2 self-assigned this Aug 18, 2023
@nirajacharya2 nirajacharya2 force-pushed the notification-date-format branch 3 times, most recently from d20f1e3 to bbf53a0 Compare August 18, 2023 05:28
@nirajacharya2 nirajacharya2 force-pushed the notification-date-format branch from bbf53a0 to 076d412 Compare August 18, 2023 05:40
@nirajacharya2 nirajacharya2 force-pushed the notification-date-format branch 2 times, most recently from eb1426e to afb2d50 Compare August 18, 2023 05:56
@phil-davis phil-davis self-requested a review August 18, 2023 06:06
@nirajacharya2 nirajacharya2 force-pushed the notification-date-format branch 2 times, most recently from 1730530 to 219aa2d Compare August 18, 2023 06:53
@nirajacharya2 nirajacharya2 force-pushed the notification-date-format branch 2 times, most recently from f62aec4 to 718875e Compare August 18, 2023 08:43
saw-jan
saw-jan reviewed Aug 18, 2023
View reviewed changes
Copy link
Member

@saw-jan saw-jan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

saw-jan
saw-jan requested changes Aug 18, 2023
View reviewed changes
Copy link
Member

@saw-jan saw-jan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, use a different date than in the format

tests/acceptance/features/apiNotification/deprovisioningNotification.feature Outdated Show resolved Hide resolved
@nirajacharya2 nirajacharya2 force-pushed the notification-date-format branch from 718875e to 28d3df3 Compare August 18, 2023 10:09
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@amrita-shrestha amrita-shrestha merged commit 3156360 into master Aug 18, 2023
@delete-merged-branch delete-merged-branch bot deleted the notification-date-format branch August 18, 2023 10:56
SagarGi
SagarGi reviewed Aug 18, 2023
View reviewed changes
tests/acceptance/features/apiNotification/deprovisioningNotification.feature
Comment on lines +175 to +178
When the administrator creates a deprovisioning notification for date "<deprovision_date>" of format "<deprovision_date_format>"
Then the HTTP status code should be "200"
When user "Alice" lists all notifications
Then the HTTP status code should be "200"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

instead of double when then use And and check both status with single step.Same apply for the down scenario.

ownclouders pushed a commit that referenced this pull request Aug 18, 2023
@nirajacharya2
adding test for deprovisioning notification using date format (#7065)
1a47ddb
This was referenced Aug 18, 2023
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SagarGi SagarGi SagarGi left review comments

@saw-jan saw-jan saw-jan approved these changes

@grgprarup grgprarup Awaiting requested review from grgprarup

@SwikritiT SwikritiT Awaiting requested review from SwikritiT

@amrita-shrestha amrita-shrestha Awaiting requested review from amrita-shrestha

@PrajwolAmatya PrajwolAmatya Awaiting requested review from PrajwolAmatya

@ScharfViktor ScharfViktor Awaiting requested review from ScharfViktor

@phil-davis phil-davis Awaiting requested review from phil-davis

Assignees

@nirajacharya2 nirajacharya2

Labels
QA:team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Extend deprovisioning notification test
5 participants
@nirajacharya2 @phil-davis @SagarGi @saw-jan @amrita-shrestha