Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tests-only][full-ci]add test for sharee searches project spaces files by content #7039

Merged
merged 1 commit into from
Aug 17, 2023
Merged

[tests-only][full-ci]add test for sharee searches project spaces files by content #7039

merged 1 commit into from
Aug 17, 2023

Conversation

nabim777
Copy link
Member

@nabim777 nabim777 commented Aug 15, 2023 •
edited
Loading

Description

This PR adds the API tests for searching project space files by sharee using content. The scenarios added in this PR are

Related Issue

Motivation and Context

  • there was no test coverage for the API test for Sharee searches project files using content. so, this PR covers the require scenario test case

How Has This Been Tested?

  • test environment:
  • locally
  • CI

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@nabim777 nabim777 self-assigned this Aug 15, 2023
@nabim777 nabim777 mentioned this pull request Aug 15, 2023
Closed
51 tasks
SagarGi
SagarGi reviewed Aug 16, 2023
View reviewed changes
Copy link
Member

@SagarGi SagarGi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Scenarios LGTM 👍

@nabim777 nabim777 force-pushed the sharee-search-project-files-by-content branch from 642a073 to ba8f74e Compare August 16, 2023 04:24
@nabim777 nabim777 requested a review from SwikritiT August 16, 2023 04:49
@nabim777 nabim777 force-pushed the sharee-search-project-files-by-content branch from ba8f74e to d1fb8da Compare August 16, 2023 09:00
saw-jan
saw-jan approved these changes Aug 16, 2023
View reviewed changes
Copy link
Member

@saw-jan saw-jan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nabim777 nabim777 requested a review from saw-jan August 16, 2023 09:06
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@saw-jan saw-jan merged commit 3a03ccb into master Aug 17, 2023
@delete-merged-branch delete-merged-branch bot deleted the sharee-search-project-files-by-content branch August 17, 2023 06:51
ownclouders pushed a commit that referenced this pull request Aug 17, 2023
@nabim777
add test for sharee searches project spaces files by content (#7039)
2060b53
@nabim777 nabim777 mentioned this pull request Aug 17, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SagarGi SagarGi SagarGi left review comments

@grgprarup grgprarup Awaiting requested review from grgprarup

@amrita-shrestha amrita-shrestha Awaiting requested review from amrita-shrestha

@PrajwolAmatya PrajwolAmatya Awaiting requested review from PrajwolAmatya

@SwikritiT SwikritiT Awaiting requested review from SwikritiT

@saw-jan saw-jan Awaiting requested review from saw-jan

Assignees

@nabim777 nabim777

Labels
QA:team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nabim777 @SwikritiT @SagarGi @saw-jan