Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tests-only][full-ci]add test for sharee searches project spaces files using a tag #7036

Merged
merged 1 commit into from
Aug 18, 2023
Merged

[tests-only][full-ci]add test for sharee searches project spaces files using a tag #7036

merged 1 commit into from
Aug 18, 2023

Conversation

nabim777
Copy link
Member

@nabim777 nabim777 commented Aug 15, 2023 •
edited
Loading

Description

This PR adds the API tests for searching project space files by sharee using a tag. The scenarios added in this PR are

Related Issue

Motivation and Context

  • there was no test coverage for the API test for Sharee searches project files using a tag. so, this PR covers the require scenario test case

How Has This Been Tested?

  • test environment:
  • locally
  • CI

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@nabim777 nabim777 self-assigned this Aug 15, 2023
@nabim777 nabim777 mentioned this pull request Aug 15, 2023
Closed
51 tasks
@nabim777 nabim777 marked this pull request as ready for review August 15, 2023 09:02
@nabim777 nabim777 force-pushed the search-project-spaces-by-sharee-using-tag branch 2 times, most recently from cbff9b9 to 6066904 Compare August 16, 2023 04:29
@nabim777 nabim777 force-pushed the search-project-spaces-by-sharee-using-tag branch from 6066904 to e143157 Compare August 16, 2023 09:06
saw-jan
saw-jan approved these changes Aug 16, 2023
View reviewed changes
Copy link
Member

@saw-jan saw-jan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

SwikritiT
SwikritiT suggested changes Aug 17, 2023
View reviewed changes
Copy link
Contributor

@SwikritiT SwikritiT left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the branch is a lot of commits behind master https://github.com/owncloud/ocis/tree/search-project-spaces-by-sharee-using-tag
please rebase and push

SagarGi
SagarGi reviewed Aug 17, 2023
View reviewed changes
Copy link
Member

@SagarGi SagarGi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 please rebase it.

@nabim777 nabim777 force-pushed the search-project-spaces-by-sharee-using-tag branch from e143157 to f4ba11b Compare August 17, 2023 06:28
@nabim777 nabim777 requested a review from SwikritiT August 17, 2023 06:34
@nabim777 nabim777 force-pushed the search-project-spaces-by-sharee-using-tag branch from f4ba11b to b46fe07 Compare August 18, 2023 02:54
@nabim777 nabim777 force-pushed the search-project-spaces-by-sharee-using-tag branch from b46fe07 to e66d35b Compare August 18, 2023 03:57
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@nabim777 nabim777 requested a review from SagarGi August 18, 2023 04:42
@nabim777 nabim777 merged commit 267c16f into master Aug 18, 2023
@delete-merged-branch delete-merged-branch bot deleted the search-project-spaces-by-sharee-using-tag branch August 18, 2023 04:43
ownclouders pushed a commit that referenced this pull request Aug 18, 2023
@nabim777
add test for sharee searches project spaces files using a tag (#7036)
bab2629
@nabim777 nabim777 mentioned this pull request Aug 18, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saw-jan saw-jan saw-jan approved these changes

@SwikritiT SwikritiT SwikritiT approved these changes

@amrita-shrestha amrita-shrestha Awaiting requested review from amrita-shrestha

@grgprarup grgprarup Awaiting requested review from grgprarup

@PrajwolAmatya PrajwolAmatya Awaiting requested review from PrajwolAmatya

@SagarGi SagarGi Awaiting requested review from SagarGi

Assignees

@nabim777 nabim777

Labels
QA:team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nabim777 @SwikritiT @SagarGi @saw-jan