Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tests-only][full-ci]add api test for search files using tag in project spaces #6853

Merged
merged 1 commit into from
Aug 4, 2023
Merged

[tests-only][full-ci]add api test for search files using tag in project spaces #6853

merged 1 commit into from
Aug 4, 2023

Conversation

nabim777
Copy link
Member

@nabim777 nabim777 commented Jul 20, 2023 •
edited by saw-jan
Loading

Description

This PR adds the API tests for full search api. The scenarios added in this PR are

Related Issue

Motivation and Context

  • there was no test coverage for api test for search files using tag in project spaces. This PR covers the global search using tag on personal space and global spaces. There is only search scanerio test done only by using new Dav path. There is also done refactor on search files by tag there are some changes like:
  1. The file name is changes
  2. There is also check for search for file inside folder and subfolder

How Has This Been Tested?

  • test environment:
  • locally
  • CI

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@nabim777 nabim777 self-assigned this Jul 20, 2023
@nabim777 nabim777 mentioned this pull request Jul 20, 2023
Closed
51 tasks
@nabim777 nabim777 force-pushed the search-files-by-tag-in-Project-space branch 3 times, most recently from f6f0e07 to 2c09893 Compare July 20, 2023 12:46
amrita-shrestha
amrita-shrestha reviewed Jul 24, 2023
View reviewed changes
tests/acceptance/features/apiGraph/fullSearch.feature Outdated Show resolved Hide resolved
tests/acceptance/features/apiGraph/fullSearch.feature Outdated
Comment on lines 18 to 26
And user "Alice" has created the following tags for file "test.txt" of the space "Personal":
| tag1 |
And user "Alice" has created the following tags for file "file2.txt" of the space "Personal":
And user "Alice" has created the following tags for file "folderWithFile/fileInsideFolder.txt" of the space "Personal":
| tag1 |
And user "Alice" has created the following tags for file "folderWithFile/subFolder/fileInsideSubFolder.txt" of the space "Personal":
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think we can use table in this case like
And user "Alice" has created the following tags:
|file| tags|

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there will be changes in another scenario also so I will make this in another PR

tests/acceptance/features/apiGraph/fullSearch.feature Outdated Show resolved Hide resolved
@nabim777 nabim777 force-pushed the search-files-by-tag-in-Project-space branch from 1e71857 to bc7bc8a Compare August 1, 2023 08:26
@nabim777 nabim777 force-pushed the search-files-by-tag-in-Project-space branch 4 times, most recently from 121a928 to 92d94af Compare August 2, 2023 07:10
@nabim777 nabim777 force-pushed the search-files-by-tag-in-Project-space branch from 92d94af to fab4a77 Compare August 2, 2023 09:47
@nabim777 nabim777 requested a review from SwikritiT August 2, 2023 09:47
@nabim777 nabim777 force-pushed the search-files-by-tag-in-Project-space branch 3 times, most recently from 7b54a42 to 7ff465c Compare August 3, 2023 06:30
amrita-shrestha
amrita-shrestha reviewed Aug 3, 2023
View reviewed changes
tests/acceptance/features/bootstrap/WebDav.php
@@ -259,6 +259,7 @@ public function usingOldDavPath():void {
$this->davPath = $this->getOldDavPath();
$this->usingOldDavPath = true;
$this->customDavPath = null;
$this->usingSpacesDavPath = false;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need this?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

similar to other functions. I think it got missed out here.

@nabim777 nabim777 force-pushed the search-files-by-tag-in-Project-space branch 4 times, most recently from ecc17d0 to 01e2be5 Compare August 4, 2023 06:08
@nabim777 nabim777 force-pushed the search-files-by-tag-in-Project-space branch 2 times, most recently from b7e89ea to ad808ee Compare August 4, 2023 08:17
@nabim777 nabim777 force-pushed the search-files-by-tag-in-Project-space branch from ad808ee to 91d3533 Compare August 4, 2023 08:30
@sonarqubecloud
Copy link

sonarqubecloud bot commented Aug 4, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

warning The version of Java (11.0.17) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

saw-jan
saw-jan reviewed Aug 4, 2023
View reviewed changes
Copy link
Member

@saw-jan saw-jan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nabim777 nabim777 requested review from SwikritiT and saw-jan August 4, 2023 10:46
SwikritiT
SwikritiT approved these changes Aug 4, 2023
View reviewed changes
Copy link
Contributor

@SwikritiT SwikritiT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

amrita-shrestha
amrita-shrestha approved these changes Aug 4, 2023
View reviewed changes
Copy link
Contributor

@amrita-shrestha amrita-shrestha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@amrita-shrestha amrita-shrestha merged commit 048d67c into master Aug 4, 2023
@delete-merged-branch delete-merged-branch bot deleted the search-files-by-tag-in-Project-space branch August 4, 2023 11:44
ownclouders pushed a commit that referenced this pull request Aug 4, 2023
@nabim777
add api test for search files using tag in project spaces (#6853)
a807fe7
ownclouders pushed a commit that referenced this pull request Aug 5, 2023
@nabim777
add api test for search files using tag in project spaces (#6853)
1db718a
@nabim777 nabim777 mentioned this pull request Aug 7, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amrita-shrestha amrita-shrestha amrita-shrestha approved these changes

@SwikritiT SwikritiT SwikritiT approved these changes

@grgprarup grgprarup Awaiting requested review from grgprarup

@PrajwolAmatya PrajwolAmatya Awaiting requested review from PrajwolAmatya

@SagarGi SagarGi Awaiting requested review from SagarGi

@saw-jan saw-jan Awaiting requested review from saw-jan

Assignees

@nabim777 nabim777

Labels
QA:team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@nabim777 @SwikritiT @SagarGi @saw-jan @amrita-shrestha