-
Notifications
You must be signed in to change notification settings - Fork 187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide Search filter for locations #6713
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2403905
force-pushed
the
OCIS-3705
branch
2 times, most recently
from
July 4, 2023 13:41
4a45837
to
ef39b72
Compare
aduffeck
requested changes
Jul 4, 2023
changelog/unreleased/enhancement-add-search-filter-for-location.md
Outdated
Show resolved
Hide resolved
2403905
force-pushed
the
OCIS-3705
branch
2 times, most recently
from
July 6, 2023 09:47
78066a4
to
2f50270
Compare
2403905
force-pushed
the
OCIS-3705
branch
6 times, most recently
from
July 12, 2023 12:09
0c99d04
to
a569a49
Compare
aduffeck
requested changes
Jul 12, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm besides the problem with the "total matches" fix.
2403905
force-pushed
the
OCIS-3705
branch
2 times, most recently
from
July 12, 2023 13:49
bff28e0
to
5304142
Compare
aduffeck
approved these changes
Jul 12, 2023
Kudos, SonarCloud Quality Gate passed! |
ownclouders
pushed a commit
that referenced
this pull request
Jul 12, 2023
Provide Search filter for locations
ownclouders
pushed a commit
that referenced
this pull request
Jul 12, 2023
Provide Search filter for locations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Issue
Motivation and Context
Acceptance Criteria
oc-pattern:"scope:<uuid>/Test"
How Has This Been Tested?
1.1 Login as admin; go to the Personal; create the file 'testfile.txt'; create the folder 'nfolder' and create inside the file 'newfile.txt'.
1.2 Call the API by name and location
<oc:pattern>file scope:storage-users-1$some-admin-user-id-0000-000000000000!some-admin-user-id-0000-000000000000/nfolder</oc:pattern>
have to return only the 'newfile.txt' as a search result.Request:
Response:
2.1 Admin shared the folder with Einstein and this folder contains a subfolder.
The search request will be:
curl 'https://localhost:9200/dav/spaces/a0ca6a90-a365-4782-871e-d44447bbc668$a0ca6a90-a365-4782-871e-d44447bbc668!storage-users-1:some-admin-user-id-0000-000000000000:7abb7cb0-8dc8-4011-b485-3e5b816a136b/' \ -X 'REPORT' \ --data-raw $'<?xml version="1.0"?>\n<oc:search-files xmlns:d="DAV:" xmlns:oc="http://owncloud.org/ns">\n <d:prop>\n <oc:permissions />\n <oc:favorite />\n <oc:fileid />\n <oc:file-parent />\n <oc:name />\n <oc:owner-id />\n <oc:owner-display-name />\n <oc:shareid />\n <oc:shareroot />\n <oc:share-types />\n <oc:privatelink />\n <d:getcontentlength />\n <oc:size />\n <d:getlastmodified />\n <d:getetag />\n <d:getcontenttype />\n <d:resourcetype />\n <oc:downloadURL />\n <oc:tags />\n </d:prop>\n <oc:search>\n <oc:pattern>file scope:a0ca6a90-a365-4782-871e-d44447bbc668$a0ca6a90-a365-4782-871e-d44447bbc668!storage-users-1:some-admin-user-id-0000-000000000000:7abb7cb0-8dc8-4011-b485-3e5b816a136b/subfolder</oc:pattern>\n <oc:limit>8</oc:limit>\n </oc:search>\n</oc:search-files>' \ -ik \ -ueinstein:relativity
Screenshots (if appropriate):
Types of changes
Checklist: