Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tests-only][full-ci] refactor scenario example table #6694

Merged
merged 1 commit into from
Jul 4, 2023
Merged

[tests-only][full-ci] refactor scenario example table #6694

merged 1 commit into from
Jul 4, 2023

Conversation

PrajwolAmatya
Copy link
Contributor

@PrajwolAmatya PrajwolAmatya commented Jul 3, 2023 •
edited
Loading

Description

This PR refactors the scenario example tables in feature files.

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@PrajwolAmatya PrajwolAmatya self-assigned this Jul 3, 2023
@PrajwolAmatya PrajwolAmatya mentioned this pull request Jul 3, 2023
Closed
57 tasks
@PrajwolAmatya PrajwolAmatya force-pushed the refactor-scenarios branch 2 times, most recently from 32d6eb1 to c238a66 Compare July 3, 2023 11:33
@PrajwolAmatya PrajwolAmatya marked this pull request as ready for review July 4, 2023 03:21
SwikritiT
SwikritiT reviewed Jul 4, 2023
View reviewed changes
Copy link
Contributor

@SwikritiT SwikritiT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

others lgtm

SagarGi
SagarGi reviewed Jul 4, 2023
View reviewed changes
Copy link
Member

@SagarGi SagarGi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

amrita-shrestha
amrita-shrestha approved these changes Jul 4, 2023
View reviewed changes
Copy link
Contributor

@amrita-shrestha amrita-shrestha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

grgprarup
grgprarup approved these changes Jul 4, 2023
View reviewed changes
Copy link
Contributor

@grgprarup grgprarup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

others. lgtm

saw-jan
saw-jan reviewed Jul 4, 2023
View reviewed changes
Copy link
Member

@saw-jan saw-jan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jul 4, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@PrajwolAmatya PrajwolAmatya merged commit 941ef59 into master Jul 4, 2023
@delete-merged-branch delete-merged-branch bot deleted the refactor-scenarios branch July 4, 2023 10:09
ownclouders pushed a commit that referenced this pull request Jul 4, 2023
@PrajwolAmatya
refactor scenario example table (#6694)
a72e72e
This was referenced Jul 4, 2023
Merged
Merged
Merged
fschade pushed a commit that referenced this pull request Jul 10, 2023
@PrajwolAmatya @fschade
refactor scenario example table (#6694)
6d7fca9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SwikritiT SwikritiT SwikritiT left review comments

@SagarGi SagarGi SagarGi left review comments

@grgprarup grgprarup grgprarup approved these changes

@saw-jan saw-jan saw-jan approved these changes

@amrita-shrestha amrita-shrestha amrita-shrestha approved these changes

Assignees

@PrajwolAmatya PrajwolAmatya

Labels
QA:team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@PrajwolAmatya @grgprarup @SwikritiT @SagarGi @saw-jan @amrita-shrestha