Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tests-only][full-ci]Search files by content #6678

Merged
merged 1 commit into from
Jul 17, 2023
Merged

[tests-only][full-ci]Search files by content #6678

merged 1 commit into from
Jul 17, 2023

Conversation

nabim777
Copy link
Member

@nabim777 nabim777 commented Jun 30, 2023 •
edited
Loading

Description

This PR adds the API tests for full search api. The scenarios added in this PR are

Related Issue

Motivation and Context

  • there was no test coverage for api test for search file using context. so, this PR covers the require scenario test case

How Has This Been Tested?

  • test environment:
  • locally
  • CI

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@update-docs
Copy link

update-docs bot commented Jun 30, 2023

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@nabim777 nabim777 mentioned this pull request Jun 30, 2023
Closed
51 tasks
@nabim777 nabim777 self-assigned this Jun 30, 2023
@nabim777 nabim777 changed the title Search files by context [tests-only][full-ci]Search files by context Jun 30, 2023
@nabim777 nabim777 force-pushed the search-files-by-context branch 5 times, most recently from 373367c to f1e7fb4 Compare July 12, 2023 07:02
@nabim777 nabim777 marked this pull request as ready for review July 12, 2023 07:04
@nabim777 nabim777 force-pushed the search-files-by-context branch from f1e7fb4 to d2178f9 Compare July 13, 2023 04:57
@nabim777 nabim777 marked this pull request as draft July 13, 2023 07:01
@nabim777 nabim777 force-pushed the search-files-by-context branch 2 times, most recently from e09e1a8 to 7019f97 Compare July 13, 2023 10:55
@nabim777 nabim777 force-pushed the search-files-by-context branch 2 times, most recently from 0f17667 to 302fd15 Compare July 14, 2023 08:38
@nabim777 nabim777 marked this pull request as ready for review July 14, 2023 08:39
@nabim777 nabim777 requested a review from individual-it as a code owner July 14, 2023 08:39
@nabim777 nabim777 requested review from saw-jan and SwikritiT July 14, 2023 08:39
@nabim777 nabim777 force-pushed the search-files-by-context branch from 302fd15 to a2172e4 Compare July 14, 2023 08:41
@SwikritiT SwikritiT changed the title [tests-only][full-ci]Search files by context [tests-only][full-ci]Search files by content Jul 14, 2023
SwikritiT
SwikritiT reviewed Jul 14, 2023
View reviewed changes
.drone.star Outdated Show resolved Hide resolved
@nabim777 nabim777 force-pushed the search-files-by-context branch from a2172e4 to 401e7ef Compare July 17, 2023 04:19
saw-jan
saw-jan approved these changes Jul 17, 2023
View reviewed changes
Copy link
Member

@saw-jan saw-jan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nabim777 nabim777 force-pushed the search-files-by-context branch 2 times, most recently from d6a70c0 to 5dd9498 Compare July 17, 2023 10:20
@nabim777 nabim777 force-pushed the search-files-by-context branch from 5dd9498 to b4abc22 Compare July 17, 2023 10:43
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@grgprarup grgprarup requested review from SwikritiT and grgprarup July 17, 2023 11:33
grgprarup
grgprarup reviewed Jul 17, 2023
View reviewed changes
Copy link
Contributor

@grgprarup grgprarup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

@saw-jan saw-jan merged commit 441588b into master Jul 17, 2023
@delete-merged-branch delete-merged-branch bot deleted the search-files-by-context branch July 17, 2023 11:35
ownclouders pushed a commit that referenced this pull request Jul 17, 2023
@nabim777
search files using content (#6678)
d86d2ed
@nabim777 nabim777 mentioned this pull request Jul 21, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grgprarup grgprarup grgprarup left review comments

@saw-jan saw-jan saw-jan approved these changes

@SagarGi SagarGi Awaiting requested review from SagarGi

@amrita-shrestha amrita-shrestha Awaiting requested review from amrita-shrestha

@PrajwolAmatya PrajwolAmatya Awaiting requested review from PrajwolAmatya

@wkloucek wkloucek Awaiting requested review from wkloucek

@micbar micbar Awaiting requested review from micbar

@phil-davis phil-davis Awaiting requested review from phil-davis phil-davis is a code owner

@individual-it individual-it Awaiting requested review from individual-it individual-it is a code owner

@SwikritiT SwikritiT Awaiting requested review from SwikritiT

Assignees

@nabim777 nabim777

Labels
QA:team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@nabim777 @grgprarup @SwikritiT @SagarGi @saw-jan