Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tests-only][full-ci] added test for mail notification in diffrent languages when shared to group #6666

Merged
merged 1 commit into from
Jul 3, 2023
Merged

[tests-only][full-ci] added test for mail notification in diffrent languages when shared to group #6666

merged 1 commit into from
Jul 3, 2023

Conversation

nirajacharya2
Copy link
Contributor

@nirajacharya2 nirajacharya2 commented Jun 29, 2023 •
edited by saw-jan
Loading

Forward port PR #6655

Related Issue

Motivation and Context

How Has This Been Tested?

test environment:

  • locally

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

SagarGi
SagarGi reviewed Jun 30, 2023
View reviewed changes
Copy link
Member

@SagarGi SagarGi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@nirajacharya2 nirajacharya2 marked this pull request as ready for review June 30, 2023 07:56
@saw-jan saw-jan merged commit f15ed6b into master Jul 3, 2023
@delete-merged-branch delete-merged-branch bot deleted the mail-translation-notification-group-master branch July 3, 2023 06:28
ownclouders pushed a commit that referenced this pull request Jul 3, 2023
@nirajacharya2
added test for mail notification in diffrent languages when sharing r…
5f364c2 
…esources (#6666)
@nirajacharya2 nirajacharya2 restored the mail-translation-notification-group-master branch July 5, 2023 03:46
fschade pushed a commit that referenced this pull request Jul 10, 2023
@nirajacharya2 @fschade
added test for mail notification in diffrent languages when sharing r…
71d6a3f 
…esources (#6666)
@amrita-shrestha amrita-shrestha deleted the mail-translation-notification-group-master branch September 12, 2024 03:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SagarGi SagarGi SagarGi left review comments

@saw-jan saw-jan saw-jan approved these changes

@grgprarup grgprarup Awaiting requested review from grgprarup

@SwikritiT SwikritiT Awaiting requested review from SwikritiT

@amrita-shrestha amrita-shrestha Awaiting requested review from amrita-shrestha

@PrajwolAmatya PrajwolAmatya Awaiting requested review from PrajwolAmatya

Assignees

@nirajacharya2 nirajacharya2

Labels
QA:team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nirajacharya2 @SagarGi @saw-jan @SwikritiT