Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tests-only] [full-ci] added different roles for sharee #6638

Merged
merged 1 commit into from
Jun 27, 2023
Merged

[tests-only] [full-ci] added different roles for sharee #6638

merged 1 commit into from
Jun 27, 2023

Conversation

S-Panta
Copy link
Contributor

@S-Panta S-Panta commented Jun 27, 2023 •
edited by grgprarup
Loading

Description

This PR adds different roles for sharee and then checks for the file versioning.

Related Issue

Motivation and Context

How Has This Been Tested?

  • locally
  • ci

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@S-Panta S-Panta mentioned this pull request Jun 27, 2023
Merged
9 tasks
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@grgprarup grgprarup marked this pull request as ready for review June 27, 2023 10:20
@S-Panta S-Panta mentioned this pull request Jun 27, 2023
Closed
51 tasks
saw-jan
saw-jan reviewed Jun 27, 2023
View reviewed changes
Copy link
Member

@saw-jan saw-jan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@saw-jan saw-jan requested a review from ScharfViktor June 27, 2023 10:31
grgprarup
grgprarup approved these changes Jun 27, 2023
View reviewed changes
Copy link
Contributor

@grgprarup grgprarup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@grgprarup grgprarup merged commit 792c322 into stable-3.0 Jun 27, 2023
@delete-merged-branch delete-merged-branch bot deleted the test/sharee-checks-file-version branch June 27, 2023 11:39
ownclouders pushed a commit that referenced this pull request Jun 27, 2023
@grgprarup
Merge pull request #6638 from owncloud/test/sharee-checks-file-version
d595862 
[tests-only] [full-ci] added different roles for sharee
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ScharfViktor ScharfViktor ScharfViktor approved these changes

@saw-jan saw-jan saw-jan approved these changes

@grgprarup grgprarup grgprarup approved these changes

@SwikritiT SwikritiT Awaiting requested review from SwikritiT

@amrita-shrestha amrita-shrestha Awaiting requested review from amrita-shrestha

@PrajwolAmatya PrajwolAmatya Awaiting requested review from PrajwolAmatya

Assignees

@S-Panta S-Panta

Labels
QA:team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@S-Panta @grgprarup @saw-jan @ScharfViktor