Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tests-only][full-ci] Test for mail notification to group members if a space is shared #6633

Merged
merged 1 commit into from
Jun 27, 2023
Merged

[tests-only][full-ci] Test for mail notification to group members if a space is shared #6633

merged 1 commit into from
Jun 27, 2023

Conversation

nirajacharya2
Copy link
Contributor

@nirajacharya2 nirajacharya2 commented Jun 27, 2023 •
edited by grgprarup
Loading

Description

This PR adds the API test scenario for mail notification.

  • Scenario: group members get an email notification when someone shares a project space with the group

Related Issue

Motivation and Context

How Has This Been Tested?

test environment:

  • locally

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@nirajacharya2 nirajacharya2 self-assigned this Jun 27, 2023
@nirajacharya2 nirajacharya2 mentioned this pull request Jun 27, 2023
Closed
51 tasks
@nirajacharya2 nirajacharya2 changed the title [tests-only][full-ci] added test for mail notification to group members if a space is share… [tests-only][full-ci] Test for mail notification to group members if a space is shared Jun 27, 2023
@nirajacharya2 nirajacharya2 force-pushed the mail-share2-group-notification branch from 9de5a66 to cf748b5 Compare June 27, 2023 07:23
SagarGi
SagarGi approved these changes Jun 27, 2023
View reviewed changes
Copy link
Member

@SagarGi SagarGi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

PrajwolAmatya
PrajwolAmatya reviewed Jun 27, 2023
View reviewed changes
Copy link
Contributor

@PrajwolAmatya PrajwolAmatya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@nirajacharya2 nirajacharya2 force-pushed the mail-share2-group-notification branch from cf748b5 to bee7f0c Compare June 27, 2023 10:22
saw-jan
saw-jan approved these changes Jun 27, 2023
View reviewed changes
Copy link
Member

@saw-jan saw-jan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

grgprarup
grgprarup approved these changes Jun 27, 2023
View reviewed changes
Copy link
Contributor

@grgprarup grgprarup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@grgprarup grgprarup merged commit 0c59a00 into master Jun 27, 2023
@delete-merged-branch delete-merged-branch bot deleted the mail-share2-group-notification branch June 27, 2023 11:38
ownclouders pushed a commit that referenced this pull request Jun 27, 2023
@grgprarup
Merge pull request #6633 from owncloud/mail-share2-group-notification
dc0424e 
[tests-only][full-ci] Test for mail notification to group members if a space is shared
@nirajacharya2 nirajacharya2 mentioned this pull request Jun 27, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PrajwolAmatya PrajwolAmatya PrajwolAmatya left review comments

@SwikritiT SwikritiT SwikritiT left review comments

@saw-jan saw-jan saw-jan approved these changes

@SagarGi SagarGi SagarGi approved these changes

@grgprarup grgprarup grgprarup approved these changes

@amrita-shrestha amrita-shrestha Awaiting requested review from amrita-shrestha

Assignees

@nirajacharya2 nirajacharya2

Labels
QA:team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@nirajacharya2 @grgprarup @SwikritiT @SagarGi @saw-jan @PrajwolAmatya