Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[full-ci] Bump Reva #6590

Merged
merged 2 commits into from
Jun 23, 2023
Merged

[full-ci] Bump Reva #6590

merged 2 commits into from
Jun 23, 2023

Conversation

kobergj
Copy link
Collaborator

@kobergj kobergj commented Jun 22, 2023

Bumps reva

Fixes #5139
Fixes #6555

@kobergj kobergj marked this pull request as draft June 22, 2023 13:26
@kobergj kobergj force-pushed the BumpReva branch 2 times, most recently from 36af535 to b108482 Compare June 22, 2023 14:45
@kobergj kobergj marked this pull request as ready for review June 22, 2023 14:46
@phil-davis
Copy link
Contributor

https://drone.owncloud.com/owncloud/ocis/23546/49/5

  Scenario: download a single file as different user                                                  # /drone/src/tests/acceptance/features/apiArchiver/downloadById.feature:69
    Given user "Brian" has been created with default attributes and without skeleton files            # FeatureContext::userHasBeenCreatedWithDefaultAttributesAndWithoutSkeletonFiles()
    And user "Alice" has uploaded file with content "some data" to "/textfile0.txt"                   # FeatureContext::userHasUploadedAFileWithContentTo()
    When user "Brian" downloads the archive of "/textfile0.txt" of user "Alice" using the resource id # ArchiverContext::userDownloadsTheArchiveOfItemOfUser()
    Then the HTTP status code should be "404"                                                         # FeatureContext::thenTheHTTPStatusCodeShouldBe()
      HTTP status code 200 is not the expected value 404
      Failed asserting that 200 matches expected '404'.

It seems that Brian is now able to access a file that belongs to Alice. That needs to be investigated - is it the server code, or is the test doing something unexpected?

@kobergj
Copy link
Collaborator Author

kobergj commented Jun 23, 2023

Kind of. He gets the not found error message with no 404 status code but 200 instead. I'm investigating...

@kobergj
Copy link
Collaborator Author

kobergj commented Jun 23, 2023

Needs another reva fix unforty: cs3org/reva#4010

@phil-davis
Copy link
Contributor

https://github.com/kobergj/ocis/tree/BumpReva
This branch is 2 commits ahead, 13 commits behind owncloud:master.

I'm not sure if there was anything important in the most recent 13 commits, but I think that GitHub does an auto-merging anyway when it provides the branch contents to drone CI.

Signed-off-by: jkoberg <[email protected]>
@kobergj
Copy link
Collaborator Author

kobergj commented Jun 23, 2023

You are right as always 😄 I rebased to current master to minimize risk.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Contributor

@phil-davis phil-davis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if CI passes.

@phil-davis phil-davis merged commit 971115d into owncloud:master Jun 23, 2023
ownclouders pushed a commit that referenced this pull request Jun 23, 2023
@kobergj kobergj deleted the BumpReva branch June 23, 2023 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants