Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add web post redirect uri config #6583

Merged
merged 2 commits into from
Jun 23, 2023
Merged

add web post redirect uri config #6583

merged 2 commits into from
Jun 23, 2023

Conversation

micbar
Copy link
Contributor

@micbar micbar commented Jun 21, 2023

Description

Enhancement: Make the post logout redirect uri configurable

We added a config option to change the redirect uri after the logout action of the web client.

#6536

Related Issue

  • Fixes <issue_link>

Motivation and Context

How Has This Been Tested?

  • test environment:
  • test case 1:
  • test case 2:
  • ...

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@micbar micbar requested a review from kulmann as a code owner June 21, 2023 17:12
@micbar micbar requested a review from wkloucek June 21, 2023 17:13
@micbar
Copy link
Contributor Author

micbar commented Jun 21, 2023

@mmattel you are scope creeping my PR, you suggestions are applying to stuff which is not part of this PR

@mmattel
Copy link
Contributor

mmattel commented Jun 21, 2023

The files view show that this got changed. I take care that the docs part for the changes shown is correct.

@micbar
Copy link
Contributor Author

micbar commented Jun 21, 2023

I only added one line, the diff is bigger because the indentation has changed.

@ownclouders
Copy link
Contributor

💥 Acceptance test Core-API-Tests-ocis-storage-3 failed. Further test are cancelled...

Co-authored-by: Martin <[email protected]>
Signed-off-by: Michael Barz <[email protected]>
@micbar micbar force-pushed the add-web-redirect-uri branch from f7b35aa to 24347e1 Compare June 22, 2023 15:58
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@micbar micbar requested a review from mmattel June 22, 2023 19:14
Copy link
Contributor

@mmattel mmattel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM from a docs pov 👍

@micbar
Copy link
Contributor Author

micbar commented Jun 23, 2023

@JammingBen Can we get an approval from the web team?

Copy link
Contributor

@JammingBen JammingBen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@micbar micbar merged commit 2421b42 into master Jun 23, 2023
@delete-merged-branch delete-merged-branch bot deleted the add-web-redirect-uri branch June 23, 2023 14:07
ownclouders pushed a commit that referenced this pull request Jun 23, 2023
@micbar micbar mentioned this pull request Jul 24, 2023
68 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants