Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tests-only][full-ci]Throw proper ocis-wrapper connection error message #6532

Merged
merged 1 commit into from
Jun 15, 2023
Merged

[tests-only][full-ci]Throw proper ocis-wrapper connection error message #6532

merged 1 commit into from
Jun 15, 2023

Conversation

amrita-shrestha
Copy link
Contributor

Description

This PR adds test code to throw better error messages when ocis-wrapper is not reachable during the test run.
Now the error will be thrown like this
Screenshot from 2023-06-15 09-43-26

Related Issue

How Has This Been Tested?

  • Locally

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@amrita-shrestha amrita-shrestha self-assigned this Jun 15, 2023
@amrita-shrestha amrita-shrestha force-pushed the throw-proper-connection-error-msg branch from 377ef21 to 92c7b0f Compare June 15, 2023 04:10
SwikritiT
SwikritiT approved these changes Jun 15, 2023
View reviewed changes
Copy link
Contributor

@SwikritiT SwikritiT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@amrita-shrestha amrita-shrestha force-pushed the throw-proper-connection-error-msg branch from 92c7b0f to c305d2e Compare June 15, 2023 09:26
@SwikritiT
Copy link
Contributor

Reminder to backport this in stable as well

saw-jan
saw-jan approved these changes Jun 15, 2023
View reviewed changes
Copy link
Member

@saw-jan saw-jan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@SwikritiT SwikritiT merged commit 3cdc3bc into master Jun 15, 2023
@delete-merged-branch delete-merged-branch bot deleted the throw-proper-connection-error-msg branch June 15, 2023 10:37
ownclouders pushed a commit that referenced this pull request Jun 15, 2023
@amrita-shrestha
Throw proper ocis-wrapper connection error message (#6532)
1065278
fschade pushed a commit that referenced this pull request Jul 10, 2023
@amrita-shrestha @fschade
Throw proper ocis-wrapper connection error message (#6532)
8c669d9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SwikritiT SwikritiT SwikritiT approved these changes

@saw-jan saw-jan saw-jan approved these changes

@ScharfViktor ScharfViktor ScharfViktor approved these changes

@SagarGi SagarGi Awaiting requested review from SagarGi

@PrajwolAmatya PrajwolAmatya Awaiting requested review from PrajwolAmatya

Assignees

@amrita-shrestha amrita-shrestha

Labels
QA:team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

better error reporting needed when ociswrapper is not reachable in test runs
4 participants
@amrita-shrestha @SwikritiT @saw-jan @ScharfViktor