Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

modify docker-compose file to work with mono repo #650

Merged
merged 1 commit into from
Oct 6, 2020

Conversation

C0rby
Copy link
Contributor

@C0rby C0rby commented Oct 5, 2020

added volumes for the different submodules to make the docker compose file work with the replaces in go.mod

Fixes: owncloud/product#242

@C0rby C0rby requested review from butonic, kulmann and refs October 5, 2020 16:24
@C0rby C0rby self-assigned this Oct 5, 2020
@update-docs
Copy link

update-docs bot commented Oct 5, 2020

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

added volumes for the different submodules to make the docker compose file work with the replaces in go.mod

Signed-off-by: David Christofas <[email protected]>
Copy link
Contributor

@micbar micbar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 😄

@C0rby C0rby force-pushed the fix-eos-docker-compose branch from 69b5d47 to d4ba9d4 Compare October 6, 2020 07:07
Copy link
Member

@butonic butonic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/reva is going to be dropped. /ocis-reva will be renamed to /storage ... but that is future work

@C0rby C0rby merged commit af3b8a7 into master Oct 6, 2020
@delete-merged-branch delete-merged-branch bot deleted the fix-eos-docker-compose branch October 6, 2020 07:55
ownclouders pushed a commit that referenced this pull request Oct 6, 2020
Merge: 91ff99e d4ba9d4
Author: David Christofas <[email protected]>
Date:   Tue Oct 6 09:55:51 2020 +0200

    Merge pull request #650 from owncloud/fix-eos-docker-compose

    modify docker-compose file to work with mono repo
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

EOS broken in mono-repo
4 participants