Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[test-only] Fix code expectation #6464

Merged
merged 2 commits into from
Jun 7, 2023
Merged

[test-only] Fix code expectation #6464

merged 2 commits into from
Jun 7, 2023

Conversation

ScharfViktor
Copy link
Contributor

I reopened #3516

  • changed createUser tests and delete tests from expected failures
  • federated sharee is not implement in OCIS (will be near in the feature) so I linked tests with existing issue Make federation tests work #1329

@2403905 we should have failed tests with a link to the issue in the expected failures file, and the issue should not be closed. (if the issue is closed -> that means no tests in the list)

@update-docs
Copy link

update-docs bot commented Jun 7, 2023

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

Copy link
Contributor

@SwikritiT SwikritiT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ownclouders
Copy link
Contributor

💥 Acceptance test localApiTests-apiSpaces-ocis failed. Further test are cancelled...

@ScharfViktor ScharfViktor merged commit 7c3215a into master Jun 7, 2023
@delete-merged-branch delete-merged-branch bot deleted the fixCodeExpectation branch June 7, 2023 11:41
ownclouders pushed a commit that referenced this pull request Jun 7, 2023
* fix code expectation

* fix
fschade pushed a commit that referenced this pull request Jul 10, 2023
* fix code expectation

* fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants