Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add uppy companion url config #6453

Merged
merged 1 commit into from
Jun 7, 2023
Merged

Conversation

JammingBen
Copy link
Contributor

Description

The config can be set via env var WEB_OPTION_UPLOAD_COMPANION_URL. This is needed for owncloud/web#9150.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

@JammingBen JammingBen requested a review from kulmann as a code owner June 6, 2023 10:10
@micbar
Copy link
Contributor

micbar commented Jun 6, 2023

sonarcloud complains about the variable name

@JammingBen JammingBen force-pushed the add-companion-url-config branch from e79ca75 to 73d65a2 Compare June 6, 2023 11:24
@ownclouders
Copy link
Contributor

💥 Acceptance test localApiTests-apiSpaces-ocis failed. Further test are cancelled...

@JammingBen JammingBen force-pushed the add-companion-url-config branch from 73d65a2 to 74ca24d Compare June 6, 2023 14:17
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jun 6, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@JammingBen JammingBen merged commit e14c2ea into master Jun 7, 2023
@delete-merged-branch delete-merged-branch bot deleted the add-companion-url-config branch June 7, 2023 10:10
ownclouders pushed a commit that referenced this pull request Jun 7, 2023
@micbar micbar mentioned this pull request Jun 8, 2023
13 tasks
@micbar micbar mentioned this pull request Jul 24, 2023
68 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants