[WIP] Performance tunig #6443
[WIP] Performance tunig #6443
Conversation
Signed-off-by: Jörn Friedrich Dreyer <[email protected]>
Signed-off-by: Jörn Friedrich Dreyer <[email protected]>
Signed-off-by: Jörn Friedrich Dreyer <[email protected]>
Signed-off-by: Jörn Friedrich Dreyer <[email protected]>
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
| MountID string `yaml:"mount_id" env:"STORAGE_SHARES_MOUNT_ID" desc:"Mount ID of this storage. Admins can set the ID for the storage in this config option manually which is then used to reference the storage. Any reasonable long string is possible, preferably this would be an UUIDv4 format."` | ||
| ReadOnly bool `yaml:"readonly" env:"STORAGE_SHARES_READ_ONLY" desc:"Set this storage to be read-only."` | ||
| SharesProviderEndpoint string `yaml:"user_share_provider_endpoint" env:"STORAGE_SHARES_USER_SHARE_PROVIDER_ENDPOINT" desc:"GRPC endpoint of the SHARING service."` | ||
| MountID string `yaml:"mount_id" env:"STORAGE_SHARES_MOUNT_ID" desc:"Mount ID of this storage. Admins can set the ID for the storage in this config option manually which is then used to reference the storage. Any reasonable long string is possible, preferably this would be an UUIDv4 format."` |
There was a problem hiding this comment.
Mount ID of this storage When using this, it means a particular one out of a described context, but there is no context written. Use the, which is open or rephrase to tell which storage is meant. Reading the text I recommend anyways to name which storage is meant, especially because you can set it to read only.
Needs maybe an additional description in the readme because of the ability to be set to read only to tell the admin more details.
|
|
||
| // StatCache holds cache config | ||
| type StatCache struct { | ||
| Store string `yaml:"store" env:"OCIS_CACHE_STORE;STORAGE_SHARES_STAT_CACHE_STORE" desc:"The type of the cache store. Supported values are: 'memory', 'ocmem', 'etcd', 'redis', 'redis-sentinel', 'nats-js', 'noop'. See the text description for details."` |
There was a problem hiding this comment.
This adds caching to the storage-shares service - needs an addon to the service readme - you can take as reference the content from the storage-users readme as it contains a stat cache too.
companion to cs3org/reva#3932