Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix disable users by group #6435

Merged
merged 1 commit into from
Jun 5, 2023
Merged

fix disable users by group #6435

merged 1 commit into from
Jun 5, 2023

Conversation

micbar
Copy link
Contributor

@micbar micbar commented Jun 2, 2023

Description

Bugfix: Fix error message when disabling users

When we disable users by adding them to a group we do not need to update the user entry.

Graph Request

curl 'https://###.owncloud.works/graph/v1.0/users/9327e0c1-6dc7-4edd-a0a3-03d47c3ade70' \
  -X 'PATCH' \
  --data-raw '{"accountEnabled":false}' \
  --compressed

Graph Response (403)

{
    "error": {
        "code": "notAllowed",
        "innererror": {
            "date": "2023-06-02T16:01:34Z",
            "request-id": "b1e1cf5c-f658-4aa0-9196-b163bec831ae"
        },
        "message": "error updating user"
    }
}

Related Issue

  • Fixes <issue_link>

Motivation and Context

How Has This Been Tested?

  • test environment:
  • test case 1:
  • test case 2:
  • ...

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@update-docs
Copy link

update-docs bot commented Jun 2, 2023

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@ownclouders
Copy link
Contributor

@micbar micbar force-pushed the fix-disable-users branch from 650ab1b to 58d8c1a Compare June 2, 2023 15:43
@micbar micbar marked this pull request as ready for review June 2, 2023 15:43
@micbar micbar requested review from rhafer, Excds, kobergj and butonic June 2, 2023 15:43
@sonarcloud
Copy link

sonarcloud bot commented Jun 2, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@micbar micbar merged commit 3385b07 into master Jun 5, 2023
@delete-merged-branch delete-merged-branch bot deleted the fix-disable-users branch June 5, 2023 08:17
ownclouders pushed a commit that referenced this pull request Jun 5, 2023
@micbar micbar mentioned this pull request Jun 6, 2023
86 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants