Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tests-only][full-ci]Extend notification related tests #6365

Merged
merged 1 commit into from
May 31, 2023
Merged

[tests-only][full-ci]Extend notification related tests #6365

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
43 changes: 43 additions & 0 deletions tests/acceptance/features/apiNotification/notification.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -240,3 +240,46 @@ Feature: Notification
| resource |
| textfile1.txt |
| my_data |


Scenario Outline: get a notification about a file share in various languages
Given user "Brian" has switched the system language to "<language>"
And user "Alice" has shared entry "textfile1.txt" with user "Brian" with permissions "17"
When user "Brian" lists all notifications
Then the HTTP status code should be "200"
And the JSON response should contain a notification message with the subject "<subject>" and the message-details should match
"""
{
"type": "object",
"required": [
"message"
],
"properties": {
"message": {
"type": "string",
"enum": [
"<message>"
]
}
}
}
"""
Examples:
| language | subject | message |
| de | Neue Freigabe | Alice Hansen hat textfile1.txt mit Ihnen geteilt |
| en | Resource shared | Alice Hansen shared textfile1.txt with you |
| es | Recurso compartido | Alice Hansen compartió textfile1.txt contigo |


Scenario Outline: notifications related to a resource get deleted when the resource is deleted
Given user "Alice" has shared entry "<resource>" with user "Brian"
And user "Brian" has accepted share "/<resource>" offered by user "Alice"
And user "Alice" has unshared entity "<resource>" shared to "Brian"
And user "Alice" has deleted entity "/<resource>"
When user "Brian" lists all notifications
Then the HTTP status code should be "200"
And the notifications should be empty
Examples:
| resource |
| textfile1.txt |
| my_data |
11 changes: 11 additions & 0 deletions tests/acceptance/features/bootstrap/NotificationContext.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,6 +104,17 @@ public function userListAllNotifications(string $user):void {
$this->featureContext->setResponse($response);
}

/**
* @Then the notifications should be empty
*
* @return void
* @throws Exception
*/
public function theNotificationsShouldBeEmpty(): void {
$notifications = $this->featureContext->getJsonDecodedResponseBodyContent()->ocs->data;
Assert::assertNull($notifications, "response should not contain any notification");
}

/**
* @Then /^the JSON response should contain a notification message with the subject "([^"]*)" and the message-details should match$/
*
Expand Down
16 changes: 7 additions & 9 deletions tests/acceptance/features/bootstrap/WebDav.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3354,16 +3354,16 @@ public function userDeletesFile(string $user, string $file):void {
}

/**
* @Given /^user "([^"]*)" has (deleted|unshared) (file|folder) "([^"]*)"$/
* @Given /^user "([^"]*)" has (deleted|unshared) (?:file|folder|entity) "([^"]*)"$/
*
* @param string $user
* @param string $deletedOrUnshared
* @param string $fileOrFolder
* @param string $entry
*
* @return void
* @throws Exception
*/
public function userHasDeletedFile(string $user, string $deletedOrUnshared, string $fileOrFolder, string $entry):void {
public function userHasDeletedFile(string $user, string $deletedOrUnshared, string $entry):void {
$user = $this->getActualUsername($user);
$this->userDeletesFile($user, $entry);
// If the file or folder was there and got deleted then we get a 204
Expand All @@ -3380,30 +3380,28 @@ public function userHasDeletedFile(string $user, string $deletedOrUnshared, stri

$this->theHTTPStatusCodeShouldBe(
["204"],
"HTTP status code was not 204 while trying to $deleteText $fileOrFolder '$entry' for user '$user'"
"HTTP status code was not 204 while trying to $deleteText resource '$entry' for user '$user'"
);
$this->emptyLastHTTPStatusCodesArray();
}

/**
* @Given /^user "([^"]*)" has (deleted|unshared) the following (files|folders|resources)$/
* @Given /^user "([^"]*)" has (deleted|unshared) the following (?:files|folders|resources)$/
*
* @param string $user
* @param string $deletedOrUnshared
* @param string $fileOrFolder
* @param TableNode $table
*
* @return void
* @throws Exception
*/
public function userHasDeletedFollowingFiles(string $user, string $deletedOrUnshared, string $fileOrFolder, TableNode $table):void {
public function userHasDeletedFollowingFiles(string $user, string $deletedOrUnshared, TableNode $table):void {
$this->verifyTableNodeColumns($table, ["path"]);
$paths = $table->getHash();

foreach ($paths as $file) {
$this->userHasDeletedFile($user, $deletedOrUnshared, $fileOrFolder, $file["path"]);
$this->userHasDeletedFile($user, $deletedOrUnshared, $file["path"]);
}
$this->emptyLastHTTPStatusCodesArray();
}

/**
Expand Down