Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[full-ci] [tests-only] Removed tag personalSpace, and refactored the example tables #6250

Merged
merged 2 commits into from
May 25, 2023

Conversation

grgprarup
Copy link
Contributor

@grgprarup grgprarup commented May 8, 2023

Description

The scenarios with personalSpace tag are refactored. This PR merges the example tables separated for spaces and other Dav paths.

Related Issue

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@grgprarup grgprarup self-assigned this May 8, 2023
@grgprarup grgprarup added QA:team and removed QA:team labels May 8, 2023
@grgprarup grgprarup force-pushed the refactor-scenarios-with-personalspace-tag branch 4 times, most recently from 5752d8d to 5a61a0b Compare May 11, 2023 09:34
@ownclouders
Copy link
Contributor

E2E tests failed: https://drone.owncloud.com/owncloud/ocis/22316/89/1

💥 To see the trace, please open the link in the console ...

npx playwright show-trace https://cache.owncloud.com/public/owncloud/ocis/22316/tracing/public-link-for-space-alice-2023-5-11-09-54-00.zip

@grgprarup grgprarup force-pushed the refactor-scenarios-with-personalspace-tag branch 2 times, most recently from 4b5c0e8 to 889fda1 Compare May 12, 2023 07:00
@grgprarup grgprarup force-pushed the refactor-scenarios-with-personalspace-tag branch 7 times, most recently from 7c63571 to 80bed84 Compare May 24, 2023 04:52
@grgprarup grgprarup marked this pull request as ready for review May 24, 2023 05:49
@grgprarup grgprarup requested review from amrita-shrestha, saw-jan, SwikritiT, SagarGi and PrajwolAmatya and removed request for amrita-shrestha May 24, 2023 05:50
@grgprarup grgprarup force-pushed the refactor-scenarios-with-personalspace-tag branch from 80bed84 to c2a44cc Compare May 24, 2023 05:51
Copy link
Member

@saw-jan saw-jan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@grgprarup grgprarup force-pushed the refactor-scenarios-with-personalspace-tag branch 2 times, most recently from a4eb468 to d55878f Compare May 24, 2023 11:15
@grgprarup grgprarup force-pushed the refactor-scenarios-with-personalspace-tag branch from d55878f to 9b0840a Compare May 25, 2023 03:28
Copy link
Member

@SagarGi SagarGi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 if CI is green.

Copy link
Contributor

@amrita-shrestha amrita-shrestha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@amrita-shrestha
Copy link
Contributor

@grgprarup rebase your PR

@grgprarup grgprarup force-pushed the refactor-scenarios-with-personalspace-tag branch from 9b0840a to c91a269 Compare May 25, 2023 10:39
@grgprarup grgprarup force-pushed the refactor-scenarios-with-personalspace-tag branch from c91a269 to c4e02cf Compare May 25, 2023 11:20
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@saw-jan saw-jan merged commit d31f544 into master May 25, 2023
@delete-merged-branch delete-merged-branch bot deleted the refactor-scenarios-with-personalspace-tag branch May 25, 2023 12:05
ownclouders pushed a commit that referenced this pull request May 25, 2023
…example tables (#6250)

* Refactored personalSpace tagged scenarios

* Fixed line numbers in expected failure
fschade pushed a commit that referenced this pull request Jul 10, 2023
…example tables (#6250)

* Refactored personalSpace tagged scenarios

* Fixed line numbers in expected failure
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants