Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[full-ci] [tests-only] Change user role #6040

Merged
merged 1 commit into from
May 24, 2023
Merged

[full-ci] [tests-only] Change user role #6040

merged 1 commit into from
May 24, 2023

Conversation

grgprarup
Copy link
Contributor

@grgprarup grgprarup commented Apr 13, 2023 •
edited
Loading

Description

This PR adds the scenarios for changing the role of users,

  • Scenario Outline: admin user changes the role of another user with different roles
  • Scenario Outline: admin user tries to change his/her own role

Related Issue

How Has This Been Tested?

  • Locally
  • 🤖

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@grgprarup grgprarup mentioned this pull request Apr 13, 2023
Closed
2 tasks
@grgprarup grgprarup force-pushed the change-user-role branch 2 times, most recently from ec6d9f8 to 0b36502 Compare May 22, 2023 10:23
@grgprarup grgprarup self-assigned this May 22, 2023
@grgprarup grgprarup marked this pull request as ready for review May 22, 2023 11:21
SagarGi
SagarGi reviewed May 23, 2023
View reviewed changes
Copy link
Member

@SagarGi SagarGi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

saw-jan
saw-jan reviewed May 23, 2023
View reviewed changes
Copy link
Member

@saw-jan saw-jan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@grgprarup grgprarup requested a review from SwikritiT May 23, 2023 09:31
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@saw-jan saw-jan requested a review from ScharfViktor May 23, 2023 09:39
@grgprarup grgprarup merged commit 768044c into master May 24, 2023
@delete-merged-branch delete-merged-branch bot deleted the change-user-role branch May 24, 2023 03:47
ownclouders pushed a commit that referenced this pull request May 24, 2023
@grgprarup
Merge pull request #6040 from owncloud/change-user-role
efac87f 
[full-ci] [tests-only] Change user role
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saw-jan saw-jan saw-jan left review comments

@SagarGi SagarGi SagarGi left review comments

@ScharfViktor ScharfViktor ScharfViktor approved these changes

@amrita-shrestha amrita-shrestha Awaiting requested review from amrita-shrestha

@PrajwolAmatya PrajwolAmatya Awaiting requested review from PrajwolAmatya

@SwikritiT SwikritiT Awaiting requested review from SwikritiT

Assignees

@grgprarup grgprarup

Labels
QA:team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@grgprarup @SwikritiT @SagarGi @saw-jan @ScharfViktor