Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add SSE to userlog #5998

Merged
merged 7 commits into from
Jun 29, 2023
Merged

Add SSE to userlog #5998

merged 7 commits into from
Jun 29, 2023

Conversation

kobergj
Copy link
Collaborator

@kobergj kobergj commented Apr 3, 2023 •
edited
Loading

Alternate approach to #5286

Adds sse (Server-Sent Events) functionality to userlog

How to test sse functionality:

  • start ocis from this branch
  • connect to sse endpoint
curl --insecure -X GET -v -u einstein:relativity https://localhost:9200/ocs/v2.php/apps/notifications/api/v1/notifications/sse
  • share something with einstein or invite him to a space
  • see sse notification (also you will still get notification via web)
  • changing language will affect future notifications without reconnecting to sse endpoint

@update-docs
Copy link

update-docs bot commented Apr 3, 2023

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@kobergj kobergj mentioned this pull request Apr 3, 2023
Closed
9 tasks
@sonarqubecloud
Copy link

sonarqubecloud bot commented Apr 4, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

28.9% 28.9% Coverage
0.0% 0.0% Duplication

@kobergj kobergj force-pushed the AddSSEToUserlog branch from 9f8d299 to 6c74b07 Compare May 23, 2023 07:47
@kobergj kobergj force-pushed the AddSSEToUserlog branch 2 times, most recently from fa9492c to 9fd801d Compare June 26, 2023 14:22
@mmattel mmattel mentioned this pull request Jun 27, 2023
Closed
kobergj
kobergj commented Jun 28, 2023
View reviewed changes
services/userlog/README.md Outdated Show resolved Hide resolved
@kobergj kobergj marked this pull request as ready for review June 28, 2023 09:06
mmattel
mmattel reviewed Jun 28, 2023
View reviewed changes
services/userlog/README.md Outdated Show resolved Hide resolved
@mmattel mmattel mentioned this pull request Jun 29, 2023
Closed
kobergj and others added 7 commits June 29, 2023 14:03
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

43.6% 43.6% Coverage
0.0% 0.0% Duplication

@kobergj kobergj merged commit 5284820 into owncloud:master Jun 29, 2023
@kobergj kobergj deleted the AddSSEToUserlog branch June 29, 2023 13:02
ownclouders pushed a commit that referenced this pull request Jun 29, 2023
@kobergj
Merge pull request #5998 from kobergj/AddSSEToUserlog
5443b6d 
Add SSE to userlog
@exalate-issue-sync exalate-issue-sync bot mentioned this pull request Jul 18, 2023
Closed
@micbar micbar mentioned this pull request Jul 24, 2023
Closed
68 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmattel mmattel mmattel left review comments

@butonic butonic butonic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kobergj @butonic @mmattel