Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tests-only][full-ci] Api test for user trying to set own personal space quota #5979

Merged

Conversation

PrajwolAmatya
Copy link
Contributor

@PrajwolAmatya PrajwolAmatya commented Mar 31, 2023

Description

This PR adds the api test for user trying to set their own personal space quota.
The deleted scenarios are covered on setQuota.feature file

Related Issue

Related to issue: #5565

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@PrajwolAmatya PrajwolAmatya force-pushed the api-test-for-user-trying-to-set-own-personal-space-quota branch from 9532c0b to 4165f50 Compare March 31, 2023 09:41
@PrajwolAmatya PrajwolAmatya requested a review from saw-jan April 3, 2023 03:35
@PrajwolAmatya PrajwolAmatya force-pushed the api-test-for-user-trying-to-set-own-personal-space-quota branch from 4165f50 to 6cf8955 Compare April 3, 2023 03:53
Copy link
Contributor

@grgprarup grgprarup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Copy link
Member

@saw-jan saw-jan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT

Copy link
Member

@SagarGi SagarGi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

grgprarup

This comment was marked as duplicate.

@PrajwolAmatya PrajwolAmatya force-pushed the api-test-for-user-trying-to-set-own-personal-space-quota branch from 6cf8955 to af05c62 Compare April 3, 2023 06:43
@micbar
Copy link
Contributor

micbar commented Apr 3, 2023

I pushed a fix for the wrong status code.

@PrajwolAmatya
Copy link
Contributor Author

I pushed a fix for the wrong status code.

I will update and remove the scenarios from expected failure.

@PrajwolAmatya PrajwolAmatya force-pushed the api-test-for-user-trying-to-set-own-personal-space-quota branch 2 times, most recently from 70b469e to cc53959 Compare April 3, 2023 10:58
@PrajwolAmatya PrajwolAmatya force-pushed the api-test-for-user-trying-to-set-own-personal-space-quota branch from cc53959 to 3a8ddd1 Compare April 3, 2023 11:00
@sonarqubecloud
Copy link

sonarqubecloud bot commented Apr 3, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

Copy link
Contributor

@micbar micbar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now. 👍

@PrajwolAmatya PrajwolAmatya merged commit 7baac4f into master Apr 4, 2023
@delete-merged-branch delete-merged-branch bot deleted the api-test-for-user-trying-to-set-own-personal-space-quota branch April 4, 2023 06:56
ownclouders pushed a commit that referenced this pull request Apr 4, 2023
…ace quota (#5979)

* api test for user trying to set their own personal space quota

* removed duplicate scenarios for set quota

* updated expected scenario

* fix wrong status code

* updated expected failure scenario after wrong status code fix

---------

Co-authored-by: Michael Barz <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants