Antivirus

[kobergj]

Backports antivirus from experimental

[update-docs]

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

[kobergj]

New service checklist:

• Provide a readme.md for that service
  Use CamelCase for section headers.
• If a new CLI command(s) is introduced, that command must be described in the readme.
• Add the service to the makefile in the ocis repo root
• Make the service startable for binary and individual startup
  • For single binary add service to ocis/pkg/runtime
  • For individual startup add service to ocis/pkg/commands
• Add the service to .drone.star to enable ci
• Make the service appear in owncloud.dev by creating a docs/services/{service} folder and adding at least
  • an _index.md that describes the service using a specific header content that you can derive eg from the _index.md file of the idm service. Remember to adapt the service name.
  • For the content, use the text from the readme.me if you do not want to deviate, though you can write something different.
    (Note that I have atm no clue how this works when embedding images)
  • a configuration.md that pulls in the autogenerated config
• Inform doc team in an early stage to review the readme AND the environment variables created.
  (the description must reflect the behaviour AND usually has a positive code quality impact)
• Create proper description strings for envvars - see other services for examples, especially when it comes to multiple values
  (base description, set of available values, description of each value)
• When suggestable commits are created for text changes and you agree, collect them to a batch and commit them. Do not forget to rebase locally to avoid overwriting the changes made.
• If new envvars are introduced which serve the same purpose but in multiple services, an additional envvar must be added at the beginning of the list starting with OCIS_ (global envvar).
• Ensure that a service has a debug port
  (see issue: Ensure all services have a debug port #5712)
• If the new service introduces a new port for its use, the port must be added to port-ranges.md and to the readme.md / _index.md file.
• Make sure to have a function FullDefaultConfig() in pkg/config/defaults/defaultconfig.go of your service. It is needed to create the documentation
• ...

[butonic]

who do you need to discuss and decide that?

[kobergj]

Just another opinion than my own

[mmattel]

Info: some of the text suggestions were alread in the refrenced admin docs pr, but not all - fixed.
Thanks for catching 👍

[ownclouders]

E2E tests failed: https://drone.owncloud.com/owncloud/ocis/20721/67/1

💥 To see the trace, please open the link in the console ...

npx playwright show-trace https://cache.owncloud.com/public/owncloud/ocis/20721/tracing/unstructured-collection-of-testable-space-interactions-alice-2023-3-23-08-20-01.zip

npx playwright show-trace https://cache.owncloud.com/public/owncloud/ocis/20721/tracing/unstructured-collection-of-testable-space-interactions-anonymous-2023-3-23-08-20-57.zip

npx playwright show-trace https://cache.owncloud.com/public/owncloud/ocis/20721/tracing/unstructured-collection-of-testable-space-interactions-brian-2023-3-23-08-20-59.zip

npx playwright show-trace https://cache.owncloud.com/public/owncloud/ocis/20721/tracing/users-can-navigate-web-via-tiles-alice-2023-3-23-08-22-38.zip

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
8 Code Smells

0.5% Coverage
0.0% Duplication