increase allowed file size in onlyoffice #5720
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
dj4oC
reviewed
Mar 3, 2023
kobergj
approved these changes
Mar 8, 2023
| #!/bin/sh | ||
| set -e | ||
|
|
||
| # we can't mount it directly because the run-document-server.sh script wants to move it |
There was a problem hiding this comment.
I assume it wasn't possible to change run-document-server.sh script? This will get very messy when we have a lot of sh scripts that all do "something"
There was a problem hiding this comment.
We would need to vendor the complete run-document-server.sh script in our repository. It's coming from here and can change depending on the OnlyOffice version.
The proper fix from my POV would be to fix the Json library to edit the file inplace instead of moving it around.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
increase allowed file size in onlyoffice
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: