-
Notifications
You must be signed in to change notification settings - Fork 187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Invitations service #5700
Invitations service #5700
Conversation
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
E2E tests failed: https://drone.owncloud.com/owncloud/ocis/20741/68/1 💥 To see the trace, please open the link in the console ...
npx playwright show-trace https://cache.owncloud.com/public/owncloud/ocis/20741/tracing/multiple-spaces-can-be-managed-at-once-in-the-admin-settings-via-the-batch-actions-alice-2023-3-23-10-42-13.zipnpx playwright show-trace https://cache.owncloud.com/public/owncloud/ocis/20741/tracing/users-can-navigate-web-via-tiles-alice-2023-3-23-10-55-27.zip |
You need to add the |
Since this is a new service this list might be helpful not to forget anything: #5710 |
@mmattel can you point to a service that adds the cli in the readme? And how do I make the docs use the README.md? |
Have a look at the referenced issue, I removed that item and added a better description in: |
Q: will the invitations service introduce a new port for its work? |
yes, but it will pick a random free port and register with the service registry: https://github.com/owncloud/ocis/pull/5700/files#diff-d771144a7c500156a0ed3657019b7def82df21e79ebc901756caa91dfc335237R25 If you want to set a specific port it can be done https://github.com/owncloud/ocis/pull/5700/files#diff-41fd01f62653382faadeeca0ab7a3547acd1ac91a023700c541acb41c66119cbR15 |
Signed-off-by: Jörn Friedrich Dreyer <[email protected]>
Signed-off-by: Jörn Friedrich Dreyer <[email protected]>
Co-authored-by: Martin <[email protected]>
Signed-off-by: Jörn Friedrich Dreyer <[email protected]>
Signed-off-by: Jörn Friedrich Dreyer <[email protected]>
As keycloak already supports everything needed for the required invitation flow, it's ideal to use as the first backend to create users and to send them invitation mails. This PR implements that as the first and (for now) only backend.
Co-authored-by: Martin <[email protected]>
Co-authored-by: Martin <[email protected]>
Co-authored-by: Martin <[email protected]>
} | ||
|
||
// Backend defines the behaviour of a user backend. | ||
type Backend interface { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
when adding graph we can move this to the common package
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
libregraph invitation service structs should be actually moved to libregraph in a subsequent pr
Kudos, SonarCloud Quality Gate passed! |
This PR introduces an invitation service that will alloww adding guest accounts.
It is based on the MS Graph API for invitations and will use the second option:
Todo
User.Invite.All
permissionUser.Invite.All
orUser.ReadWrite.All
(or the current equivalent) permissionsnew service TODO from #5710
If a new CLI command(s) is introduced, that command must be described in the readme.autogeneratedocis/pkg/runtime
ocis/pkg/commands
.drone.star
to enable ciowncloud.dev
(needs a description what needs to be added so it appears automatically)
(the description must reflect the behaviour AND usually has a positive code quality impact)
(base description, set of available values, description of each value)
OCIS_
(global envvar).