Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make graph/education API errors more consistent #5682

Merged
merged 1 commit into from
Feb 28, 2023
Merged

make graph/education API errors more consistent #5682

merged 1 commit into from
Feb 28, 2023

Conversation

C0rby
Copy link
Contributor

@C0rby C0rby commented Feb 28, 2023

Aligned the error messages when creating schools and classes fail and changed the response code from 500 to 409.

Fixes: #5660

@C0rby C0rby requested review from rhafer, butonic and micbar February 28, 2023 14:26
@C0rby C0rby self-assigned this Feb 28, 2023
@sonarcloud
Copy link

sonarcloud bot commented Feb 28, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

23.5% 23.5% Coverage
0.0% 0.0% Duplication

@C0rby C0rby merged commit 0a2fc8d into master Feb 28, 2023
@delete-merged-branch delete-merged-branch bot deleted the graph-education-errors branch February 28, 2023 19:49
ownclouders pushed a commit that referenced this pull request Feb 28, 2023
commit 0a2fc8d
f679642 
Merge: e04f88f 0fadc79
Author: David Christofas <[email protected]>
Date:   Tue Feb 28 20:49:29 2023 +0100

    Merge pull request #5682 from owncloud/graph-education-errors

    make graph/education API errors more consistent
@micbar micbar mentioned this pull request May 3, 2023
Closed
89 tasks
@ScharfViktor ScharfViktor mentioned this pull request May 4, 2023
Closed
86 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@micbar micbar micbar approved these changes

@rhafer rhafer Awaiting requested review from rhafer

@butonic butonic Awaiting requested review from butonic

Assignees

@C0rby C0rby

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

graph/education: Inconsistent status codes and error messages
2 participants
@C0rby @micbar