Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

graph/education: Inconsistent status codes and error messages #5660

Closed
rhafer opened this issue Feb 27, 2023 · 0 comments · Fixed by #5682
Closed

graph/education: Inconsistent status codes and error messages #5660

rhafer opened this issue Feb 27, 2023 · 0 comments · Fixed by #5682

Comments

@rhafer
Copy link
Contributor

rhafer commented Feb 27, 2023

Creating an already existing user or school currently return a 500 HTTP Status. 409 might be better here.

Also the error messages for classes and schools differ slightly. We should align this

For schools:

{"error":{"code":"generalException","innererror":{"date":"2023-02-24T13:21:39Z","request-id":"cea2771d93a1c97200c84f44ed13b335"},"message":"nameAlreadyExists"}}

For Classes:

{"error":{"code":"generalException","innererror":{"date":"2023-02-24T13:01:38Z","request-id":"e9551976e0d1fab9072ee803be3755ab"},"message":"LDAP Result Code 68 \"Entry Already Exists\": "}}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant