Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[test-only] ApiTest. Disable/enable user #5639

Merged
merged 3 commits into from
Mar 6, 2023
Merged

[test-only] ApiTest. Disable/enable user #5639

merged 3 commits into from
Mar 6, 2023

Conversation

ScharfViktor
Copy link
Contributor

@ScharfViktor ScharfViktor commented Feb 23, 2023 •
edited
Loading

Changed tests:

  • creating user with "accountEnabled" by default
  • getting users with different filter- check parameter "accountEnabled"

Added tests:

  • disabling user.
  • enabling user
  • adding/deleting disabled user to/from group
  • trying to create user with same name as disabled/deleted user

@update-docs
Copy link

update-docs bot commented Feb 23, 2023

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@ScharfViktor ScharfViktor mentioned this pull request Feb 27, 2023
Closed
@ScharfViktor ScharfViktor force-pushed the disableUser branch 2 times, most recently from f1ab3b1 to 502a617 Compare February 27, 2023 16:05
@ownclouders
Copy link
Contributor

ownclouders commented Feb 27, 2023 •
edited
Loading

💥 Acceptance test Web-Tests-ocis-smoke-ocis-storage-2 failed. Further test are cancelled...

@ScharfViktor ScharfViktor added the Status:Needs-Review Needs review from a maintainer label Feb 28, 2023
saw-jan
saw-jan reviewed Feb 28, 2023
View reviewed changes
Copy link
Member

@saw-jan saw-jan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Others look good

@ScharfViktor ScharfViktor requested a review from saw-jan February 28, 2023 11:24
SagarGi
SagarGi reviewed Mar 2, 2023
View reviewed changes
Copy link
Member

@SagarGi SagarGi left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a simple change request.
Other LGTM 👍

tests/acceptance/features/apiGraph/getUser.feature Show resolved Hide resolved
@ScharfViktor ScharfViktor requested a review from SagarGi March 2, 2023 10:36
@ScharfViktor
Copy link
Contributor Author

if is okay can you approve it please. we need have tests in master

individual-it
individual-it requested changes Mar 3, 2023
View reviewed changes
Copy link
Member

@individual-it individual-it left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a small change request, I think the step is meant to be a Given step

tests/acceptance/features/bootstrap/GraphContext.php Outdated Show resolved Hide resolved
@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 6, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@individual-it
Copy link
Member

please backport to stable2

@individual-it individual-it merged commit 1e1b437 into master Mar 6, 2023
@delete-merged-branch delete-merged-branch bot deleted the disableUser branch March 6, 2023 11:08
ownclouders pushed a commit that referenced this pull request Mar 6, 2023
@ScharfViktor
commit 1e1b437
caa136e 
Author: Viktor Scharf <[email protected]>
Date:   Mon Mar 6 12:07:55 2023 +0100

    [test-only] ApiTest. Disable/enable user (#5639)
ScharfViktor added a commit that referenced this pull request Mar 6, 2023
@ScharfViktor
[test-only] ApiTest. Disable/enable user (#5639)
bfa2ff2
@ScharfViktor ScharfViktor mentioned this pull request Mar 6, 2023
Merged
ownclouders pushed a commit that referenced this pull request Mar 6, 2023
@ScharfViktor
commit 1e1b437
d4bc5fa 
Author: Viktor Scharf <[email protected]>
Date:   Mon Mar 6 12:07:55 2023 +0100

    [test-only] ApiTest. Disable/enable user (#5639)
ScharfViktor added a commit that referenced this pull request Mar 7, 2023
@ScharfViktor
[test-only] ApiTest. Disable/enable user (#5639) (#5739)
daddb63 
* [test-only] ApiTest. Disable/enable user (#5639)

* fix expected failures lines
ownclouders pushed a commit that referenced this pull request Mar 7, 2023
@ScharfViktor
commit daddb63
7e9feec 
Author: Viktor Scharf <[email protected]>
Date:   Tue Mar 7 09:06:22 2023 +0100

    [test-only] ApiTest. Disable/enable user (#5639) (#5739)

    * [test-only] ApiTest. Disable/enable user (#5639)

    * fix expected failures lines
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saw-jan saw-jan saw-jan approved these changes

@SagarGi SagarGi SagarGi approved these changes

@individual-it individual-it individual-it approved these changes

Assignees
No one assigned
Labels
Status:Needs-Review Needs review from a maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ScharfViktor @ownclouders @individual-it @SagarGi @saw-jan